Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

Set copyright and package license #111

Merged
tmat merged 2 commits into from
Feb 22, 2019
Merged

Set copyright and package license #111

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c1b905
Set copyright and package license
tmat Feb 21, 2019
867f504
Suppress NU5125
tmat Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<ImportNetSdkFromRepoToolset>false</ImportNetSdkFromRepoToolset>
</PropertyGroup>

<Import Project="Sdk.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<PropertyGroup Condition="'$(CopyrightNetFoundation)' != ''">
<Copyright>$(CopyrightNetFoundation)</Copyright>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
</PropertyGroup>

<PropertyGroup>
<NoWarn>$(NoWarn);NU5125</NoWarn>
Copy link
Copy Markdown
Contributor

@nguerrera nguerrera Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is NU5125?

Copy link
Copy Markdown
Member Author

@tmat tmat Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NeGet warning that we should not use LicenseUrl. Once the Arcade PR is merge we can remove.

<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
<DebugType>embedded</DebugType>
Copy link
Copy Markdown
Contributor

@nguerrera nguerrera Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete aside and existing, but should we be forcing embedded here?

Copy link
Copy Markdown
Contributor

@nguerrera nguerrera Feb 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@livarcocc I see this was done everywhere in move to arcade. Do you recall the rationale? I thought arcade managed the appropriate symbol type.

<DebugSymbols>true</DebugSymbols>
Expand Down