This repository was archived by the owner on Mar 23, 2021. It is now read-only.
Conversation
Member
Author
Member
Author
|
@nguerrera @dsplaisted PTAL |
nguerrera
reviewed
Feb 22, 2019
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup> | ||
| <NoWarn>$(NoWarn);NU5125</NoWarn> |
Member
Author
There was a problem hiding this comment.
NeGet warning that we should not use LicenseUrl. Once the Arcade PR is merge we can remove.
nguerrera
reviewed
Feb 22, 2019
| <PropertyGroup> | ||
| <NoWarn>$(NoWarn);NU5125</NoWarn> | ||
| <TreatWarningsAsErrors>True</TreatWarningsAsErrors> | ||
| <DebugType>embedded</DebugType> |
Contributor
There was a problem hiding this comment.
Complete aside and existing, but should we be forcing embedded here?
Contributor
There was a problem hiding this comment.
@livarcocc I see this was done everywhere in move to arcade. Do you recall the rationale? I thought arcade managed the appropriate symbol type.
nguerrera
approved these changes
Feb 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares repo for change dotnet/arcade#2003 by setting
CopyrightandPackageLicenseExpressionproperties. These values will be required to be set by each repository once dotnet/arcade#2003 is merged.In order to not break the current builds this change sets the properties conditionally. This condition can be removed once all repos switch to Arcade that has dotnet/arcade#2003.
@markwilkie