Merged
Conversation
Member
|
having a quick bite; will rebase and un-draft #49 shortly then we have CI running |
The new keyword, any, is added to Go 1.18 for the sake of readability.
It is an alias to interface{}.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Now when we have Go 1.20 we can finally switch from strings.Split[N] to strings.Cut. The code is easier and more readable, and we no longer deal with slices. There is a slight difference in behavior -- the old code was giving hints when an extra = or : was there. The new code just returns NumError. To me this is not a big deal. All the existing tests still pass. Added some new tests to cover the case of extra = signs which was not covered before. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Addressing the TODO item added by commit 7375726. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
approved these changes
Apr 15, 2026
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (did a quick rebase to get the GitHub actions running)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Wrote a set of patches that benefit from having Go 1.20 (as #36 was merged).
See individual commits for details.
- How I did it
Mostly using nvim
- How to verify it
go test- Description for the changelog
n/a
- A picture of a cute animal (not mandatory but encouraged)