Merged
Conversation
Closed
AkihiroSuda
reviewed
Aug 16, 2022
Contributor
|
@thaJeztah Can we revive this, and use (at least) go 1.20 so we can use strings.Cut? |
Keeping the go version to 1.20 for now, as this module doesn't require "latest and greatest" Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
AkihiroSuda
approved these changes
Apr 10, 2026
Member
Author
|
Ah! Thx Akihiro; I'll work on adding some basic actions on this repo as well |
Contributor
|
I think we never merged this one because we want to move this to under moby. Otherwise, I've proposed adding go.mod in PR #40 but had to remove it; see discussion here: and this issue: |
Member
Author
|
Oh! Yeah, you're right! I'd still like to move it; that said, from some other cases, I think ultimately it doesn't make a big different to have the go.mod; go modules will be confused in either case; try to redirect then either finds a go.mod with a different name, or doesn't, so perhaps it's fine to already have one, then tag -> rename -> tag with new name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping the go version to 1.20 for now, as this module doesn't require "latest and greatest"