Limit ucontext linking to arm32* and s390x arches#366
Limit ucontext linking to arm32* and s390x arches#366tianon merged 1 commit intodocker-library:masterfrom
Conversation
|
This looks good, but this seems like it's pretty easy to test with just |
|
@keithlayne yes, adding that would be really easy, and I was about to go do exactly that, but got a little stuck on which native extension we should use (it'd be awesome if there was a "hello world" of native extensions we could use that we know won't ever be pre-compiled, but I couldn't find anything -- maybe you know better 👀) |
|
I'm mostly out of the ruby world, and I never wrote a single native extension, so no. But immediately after I wrote that I was wondering basically the same thing. I thought of several ways it could be goofy. Maybe it's just a matter of generating the makefile or whatever and trying to run it for a no-op extension? I wonder if that could be bundled up into a very few files... |
|
Looks like the magic incantation is (The gem I ran into this problem on was |
|
@tianon I think you'll find bcrypt lighter/simpler than eventmachine for a quick test like this. |
|
Indeed; just tested and it builds way faster!! Thanks @bpo! ❤️ 👀 Edit: it also appears to be easier to use/debug because it isn't hiding the compiler errors in a log file like Edit 2x: and it doesn't need |
|
@tianon because I was already down this path...if you run this on Possibly the bundle gem --ext --no-coc --no-mit --test=none test
cd test
sed -i'' '/none/d' Gemfile
sed -i'' -e 's/spec\.summary.*$/spec.summary = "bogus"/' \
-e 's/spec\.authors.*$/spec.authors = ["bogus"]/' \
-e '/TODO/d' -e '/metadata/d' \
test.gemspec
apk add make gcc musl-dev git
bundle
rake build |
|
Downside of the above is that a) you already have your test 😁 and b) it doesn't cover jruby. |
|
Yeah, I've got docker-library/official-images#11192 merged now with that new test and restarted the builds here so it'll run it and validate that @yosifkit's fix is solid. 👍 |
Changes: - docker-library/ruby@74ff4b2: Merge pull request docker-library/ruby#366 from infosiftr/more-context - docker-library/ruby@bda17e3: Limit ucontext linking to specific arches
And keep
libucontext-devon those arches to ensure rubygems work. (~249kb)Fixes #365