Skip to content

feat: add support for arrays as children #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developit merged 6 commits into from
Mar 25, 2022
Merged

feat: add support for arrays as children #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05c3c2d
add support for arrays as children
theianjones Jan 21, 2022
cd7d255
fix: formatting
theianjones Jan 21, 2022
8d8fbc7
fix: more formatting
theianjones Jan 21, 2022
16776b2
format
theianjones Mar 24, 2022
8cf4c9c
add texs suggestion
theianjones Mar 24, 2022
3604adb
format
theianjones Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@ export default function h(name, attrs, ...children) {
// collapse it into the current object for MAGIC
let { name } = child;
if (name) {
obj[name] = child;
obj[name] = obj[name] ? [obj[name], child].flat() : child
delete child.name;
}
else {
} else {
obj.value = child;
}
});
Expand Down
31 changes: 31 additions & 0 deletions test/arrayFixture.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
{
"name": "webpack",
"target": "web",
"watch": true,
"entry": {
"path": "src/index.js"
},
"resolve": {
"alias": [
{
"from": "react",
"to": "preact-compat"
},
{
"from": "react-dom",
"to": "preact-compat"
}
]
Comment on lines +9 to +18
Copy link

@texastoland texastoland Jan 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme needs updated too 👏🏼

},
"plugins": {
"uglify-js": {
"opts": {
"compression": true,
"mangle": false
}
},
"custom-plugin": {
"foo": "bar"
}
}
}
55 changes: 36 additions & 19 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,50 @@
import assert from 'assert';
import h from '../src';
import fixture from './fixture.json';
import arrayFixture from './arrayFixture.json';

// example of an import'd plugin
const CustomPlugin = config => ({
...config,
name: 'custom-plugin'
const CustomPlugin = (config) => ({
...config,
name: 'custom-plugin'
});


var json = (
<webpack target="web" watch>
<entry path="src/index.js" />
<resolve>
<alias from="react" to="preact-compat" />
<alias from="react-dom" to="preact-compat" />
</resolve>
<plugins>
<uglify-js opts={{
compression: true,
mangle: false
}} />
<CustomPlugin foo="bar" />
</plugins>
</webpack>
<webpack target="web" watch>
<entry path="src/index.js" />
<resolve>
<alias from="react-dom" to="preact-compat" />
</resolve>
<plugins>
<uglify-js opts={{
compression: true,
mangle: false,
}} />
<CustomPlugin foo="bar" />
</plugins>
</webpack>
);


assert.deepEqual(json, fixture);

var arrayJson = (
<webpack target="web" watch>
<entry path="src/index.js" />
<resolve>
<alias from="react" to="preact-compat" />
<alias from="react-dom" to="preact-compat" />
</resolve>
<plugins>
<uglify-js opts={{
compression: true,
mangle: false,
}} />
<CustomPlugin foo="bar" />
</plugins>
</webpack>
);

assert.deepEqual(arrayJson, arrayFixture);

console.log('✅ success');
process.exit(0);