feat: add support for arrays as children #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@theianjones I liked your implementation too 👏🏼 Look for my review inline. |
Contributor
Author
|
@texastoland I dont see a review |
texastoland
suggested changes
Jan 27, 2022
src/index.js
Outdated
| delete child.name; | ||
| } | ||
| else { | ||
| } else { |
There was a problem hiding this comment.
Do you not have the Prettier extension installed? Make sure to add an .editorconfig to keep tabs (you mixed them throughout).
src/index.js
Outdated
Comment on lines
12
to
16
| if(obj[name]){ | ||
| obj[name] = [obj[name], child].flat() | ||
| } else { | ||
| obj[name] = child; | ||
| } |
There was a problem hiding this comment.
I might not have thought of flat 🤩
Suggested change
| if(obj[name]){ | |
| obj[name] = [obj[name], child].flat() | |
| } else { | |
| obj[name] = child; | |
| } | |
| obj[name] = obj[name] ? [obj[name], child].flat() : child |
test/index.js
Outdated
Comment on lines
14
to
24
| <entry path="src/index.js" /> | ||
| <resolve> | ||
| <alias from="react-dom" to="preact-compat" /> | ||
| </resolve> | ||
| <plugins> | ||
| <uglify-js opts={{ | ||
| compression: true, | ||
| mangle: false, | ||
| }} /> | ||
| <CustomPlugin foo="bar" /> | ||
| </plugins> |
There was a problem hiding this comment.
Unintentional whitespace changes hurt the diff.
Comment on lines
+9
to
+18
| "alias": [ | ||
| { | ||
| "from": "react", | ||
| "to": "preact-compat" | ||
| }, | ||
| { | ||
| "from": "react-dom", | ||
| "to": "preact-compat" | ||
| } | ||
| ] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3