fix: code review batch — CRITICAL+WARNING+docs (#134-137)#138
Merged
Conversation
CRITICAL: - TryUploadPage: render-time side effects → useEffect, Suspense 경계 추가 - ImageCard/SmartNav/mobile-header: native img → next/image 전환 WARNING: - AuthProvider: setInterval 미인증 유저 제외 - SpotSolutionTabs: role="tablist/tab/tabpanel" 접근성 추가 - ExploreClient: 추천 태그 상수 추출 - Rust dto: image dimensions validate(range) 추가 - Rust service: post_type 매직 스트링 → 상수 DOCS: - api-v1-routes: votes, tries 엔드포인트 추가 - web-hooks-and-stores: useVoting, useCreateTryPost 추가 - web-routes-and-features: /request/try, proxy 라우트 추가 Closes #134, #135, #136, #137 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
코드 리뷰에서 발견된 CRITICAL 3개 + WARNING 5개 + docs 누락 4개를 일괄 수정.
Changes (12 files)
CRITICAL
app/request/try/page.tsx: render-time side effects → useEffect, Suspense 래핑app/images/ImageCard.tsx:<img>→next/image(동적 width/height 지원)SmartNav.tsx,mobile-header.tsx: avatar<img>→next/imageWARNING
AuthProvider.tsx: setInterval 미인증 유저 제외SpotSolutionTabs.tsx: ARIA role 접근성ExploreClient.tsx: POPULAR_SEARCH_TAGS 상수 추출dto.rs: image_width/heightvalidate(range)추가service.rs: POST_TYPE_TRY/POST 상수화DOCS
api-v1-routes.md: votes, tries 엔드포인트web-hooks-and-stores.md: useVoting, useCreateTryPostweb-routes-and-features.md: /request/try, proxy 라우트Test plan
Closes #134, #135, #136, #137
🤖 Generated with Claude Code