Skip to content

fix: Drop duplicated received filter update #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xdustinface merged 1 commit into from
Dec 8, 2025
Merged

fix: Drop duplicated received filter update #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions dash-spv/src/sync/message_handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,20 +629,6 @@ impl<
stats_lock.last_filter_received_time = Some(std::time::Instant::now());
}

// Get the shared filter heights arc from stats
let stats_lock = self.stats.read().await;
let received_filter_heights = stats_lock.received_filter_heights.clone();
drop(stats_lock); // Release the stats lock before acquiring the mutex

// Now lock the heights and insert
let mut heights = received_filter_heights.lock().await;
heights.insert(height);
tracing::trace!(
"📊 Recorded filter received at height {} for block {}",
height,
cfilter.block_hash
);

if matches {
// Update filter match statistics
{
Expand Down