Skip to content

chore: update transifex config#542

Merged
thephez merged 1 commit intodashpay:23.0.0from
thephez:transifex-config-2025-11-26
Nov 26, 2025
Merged

chore: update transifex config#542
thephez merged 1 commit intodashpay:23.0.0from
thephez:transifex-config-2025-11-26

Conversation

@thephez
Copy link
Collaborator

@thephez thephez commented Nov 26, 2025

Keep translations

Summary by CodeRabbit

Release Notes

  • Chores
    • Updated translation synchronization configuration to preserve edited translations during resource updates across all documentation.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 26, 2025

Walkthrough

Modified .tx/config to set keep_translations from false to true across multiple documentation resource blocks. This configuration change alters translation synchronization behavior to retain edited strings during Transifex updates.

Changes

Cohort / File(s) Summary
Transifex Configuration
\.tx/config
Updated keep_translations setting from false to true across all documentation resource blocks to enable retention of edited translations during synchronization

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify that the keep_translations configuration change is intentional and applied consistently across all resource blocks
  • Confirm that this change aligns with translation workflow requirements and doesn't conflict with other synchronization settings

Possibly related PRs

  • chore: transifex updates #540: Both PRs modify the same .tx/config resource entries and specifically touch the keep_translations setting, representing related translation configuration management.

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating transifex configuration to enable keep_translations across multiple resource blocks.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e5f8d8 and aaa2467.

📒 Files selected for processing (1)
  • .tx/config (76 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: thephez
Repo: dashpay/docs PR: 534
File: locale/en/LC_MESSAGES/docs/user/masternodes/maintenance.po:175-176
Timestamp: 2025-11-12T18:09:41.377Z
Learning: In the dashpay/docs repository, .po files under locale/ directories are automated outputs generated by running the transifex/pushtx.sh script. These files should not be manually edited as changes will be overwritten on the next Transifex sync. Any corrections should be made at the source level in the original documentation files or within Transifex.
📚 Learning: 2025-11-12T18:09:41.377Z
Learnt from: thephez
Repo: dashpay/docs PR: 534
File: locale/en/LC_MESSAGES/docs/user/masternodes/maintenance.po:175-176
Timestamp: 2025-11-12T18:09:41.377Z
Learning: In the dashpay/docs repository, .po files under locale/ directories are automated outputs generated by running the transifex/pushtx.sh script. These files should not be manually edited as changes will be overwritten on the next Transifex sync. Any corrections should be made at the source level in the original documentation files or within Transifex.

Applied to files:

  • .tx/config
📚 Learning: 2025-11-10T18:51:37.016Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.

Applied to files:

  • .tx/config
📚 Learning: 2025-11-10T17:22:58.160Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-call-quick-reference.md:34-34
Timestamp: 2025-11-10T17:22:58.160Z
Learning: In the dashpay/docs repository, RPC documentation descriptions in files like `docs/core/api/remote-procedure-call-quick-reference.md` are derived from the Dash Core application help output. These descriptions should not be modified for grammar or style, as they need to remain consistent with the source application output.

Applied to files:

  • .tx/config
📚 Learning: 2025-11-10T19:11:33.355Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1702-1704
Timestamp: 2025-11-10T19:11:33.355Z
Learning: Repo: dashpay/docs — For ListDescriptors RPC, document Parameter #1 `private` (bool, default false) and note that `mnemonic` and `mnemonicpassphrase` appear only when `private=true` and the wallet was created with a mnemonic. Both fields are strings per Dash Core v23.0 help (scripts/core-rpc-tools/dash-cli-help-23.0.0.jsonl).

Applied to files:

  • .tx/config
🔇 Additional comments (1)
.tx/config (1)

12-752: Enabling keep_translations globally aligns with the stated objective

All affected resources now have keep_translations = true with replace_edited_strings = false unchanged. This matches Transifex’s “keep existing translations when updating source content” behavior, so updated source strings will preserve existing translations instead of dropping them, at the cost of potentially stale translations if source text changes significantly. That tradeoff seems intentional given the PR description.

Change is consistent across resources and the config syntax matches current Transifex client docs; I don’t see any blockers here.

If you want to double‑check against current Transifex behavior, please confirm with the latest CLI/config documentation that keep_translations still preserves translations on source updates for PO resources.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thephez thephez merged commit 2e9e9ff into dashpay:23.0.0 Nov 26, 2025
1 check passed
@thephez thephez deleted the transifex-config-2025-11-26 branch November 26, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant