Skip to content

chore: transifex updates#540

Merged
thephez merged 2 commits intodashpay:23.0.0from
thephez:transifex-config-and-push
Nov 25, 2025
Merged

chore: transifex updates#540
thephez merged 2 commits intodashpay:23.0.0from
thephez:transifex-config-and-push

Conversation

@thephez
Copy link
Collaborator

@thephez thephez commented Nov 25, 2025

Summary by CodeRabbit

  • Chores
    • Updated translation configuration with new resource management settings
    • Improved configuration file formatting and alignment for better readability

✏️ Tip: You can customize this high-level summary in your review settings.

Adds replace_edited_strings and keep_translations, but shouldn't impact anything
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Walkthrough

The .tx/config file is updated to add two new translation resource settings (replace_edited_strings = false and keep_translations = false) to each resource stanza, alongside minor whitespace formatting adjustments for alignment.

Changes

Cohort / File(s) Summary
Transifex Configuration
.tx/config
Added replace_edited_strings = false and keep_translations = false settings to each translation resource; applied formatting alignment with increased whitespace around file_filter values

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Single configuration file with repetitive, homogeneous changes (same two settings added to each resource)
  • No code logic or control flow modifications
  • Formatting changes are purely cosmetic
  • Verify consistency of new settings across all resource stanzas and validate configuration file syntax

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title 'chore: transifex updates' is directly related to the main change, which updates Transifex translation configuration settings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.tx/config (1)

44-51: Consider adding source_lang for consistency.

Some resource entries are missing the source_lang = en field while others include it. For consistency and clarity, consider adding this field to all resource configurations.

Also applies to: 53-60, 62-69, 221-228, 230-237, 239-246, 278-285, 297-304, 356-363, 365-372

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c1a4cdf and 636b191.

⛔ Files ignored due to path filters (30)
  • locale/ar/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/ar/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/de/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/de/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/el/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/el/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/en/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/en/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/es/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/es/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/fr/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/fr/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/it/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/it/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/ja/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/ja/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/ko/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/ko/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/pt/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/pt/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/ru/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/ru/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/tl/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/tl/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/vi/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/vi/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/zh_CN/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/zh_CN/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
  • locale/zh_TW/LC_MESSAGES/docs/user/developers/testnet.po is excluded by !**/*.po
  • locale/zh_TW/LC_MESSAGES/docs/user/governance/eight-steps.po is excluded by !**/*.po
📒 Files selected for processing (1)
  • .tx/config (1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: thephez
Repo: dashpay/docs PR: 534
File: locale/en/LC_MESSAGES/docs/user/masternodes/maintenance.po:175-176
Timestamp: 2025-11-12T18:09:41.377Z
Learning: In the dashpay/docs repository, .po files under locale/ directories are automated outputs generated by running the transifex/pushtx.sh script. These files should not be manually edited as changes will be overwritten on the next Transifex sync. Any corrections should be made at the source level in the original documentation files or within Transifex.
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.
📚 Learning: 2025-11-12T18:09:41.377Z
Learnt from: thephez
Repo: dashpay/docs PR: 534
File: locale/en/LC_MESSAGES/docs/user/masternodes/maintenance.po:175-176
Timestamp: 2025-11-12T18:09:41.377Z
Learning: In the dashpay/docs repository, .po files under locale/ directories are automated outputs generated by running the transifex/pushtx.sh script. These files should not be manually edited as changes will be overwritten on the next Transifex sync. Any corrections should be made at the source level in the original documentation files or within Transifex.

Applied to files:

  • .tx/config
📚 Learning: 2025-11-10T18:51:37.016Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.

Applied to files:

  • .tx/config
📚 Learning: 2025-11-10T17:22:58.160Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-call-quick-reference.md:34-34
Timestamp: 2025-11-10T17:22:58.160Z
Learning: In the dashpay/docs repository, RPC documentation descriptions in files like `docs/core/api/remote-procedure-call-quick-reference.md` are derived from the Dash Core application help output. These descriptions should not be modified for grammar or style, as they need to remain consistent with the source application output.

Applied to files:

  • .tx/config
📚 Learning: 2025-11-10T19:11:33.355Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1702-1704
Timestamp: 2025-11-10T19:11:33.355Z
Learning: Repo: dashpay/docs — For ListDescriptors RPC, document Parameter #1 `private` (bool, default false) and note that `mnemonic` and `mnemonicpassphrase` appear only when `private=true` and the wallet was created with a mnemonic. Both fields are strings per Dash Core v23.0 help (scripts/core-rpc-tools/dash-cli-help-23.0.0.jsonl).

Applied to files:

  • .tx/config
🔇 Additional comments (1)
.tx/config (1)

11-12: Confirm this Transifex configuration change is intentional for your workflow.

Web search confirms your settings will work as described: with keep_translations = false, existing translations are cleared when source strings are updated, while replace_edited_strings = false preserves manual edits made in the online editor. This is a deviation from Transifex defaults, as the default for keep_translations is true (preserve translations).

Please confirm this configuration—which clears translations on each source update across all resources—aligns with your translation workflow.

@thephez thephez merged commit 8e5f8d8 into dashpay:23.0.0 Nov 25, 2025
1 check passed
@thephez thephez deleted the transifex-config-and-push branch November 25, 2025 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant