Conversation
Adds replace_edited_strings and keep_translations, but shouldn't impact anything
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.tx/config (1)
44-51: Consider adding source_lang for consistency.Some resource entries are missing the
source_lang = enfield while others include it. For consistency and clarity, consider adding this field to all resource configurations.Also applies to: 53-60, 62-69, 221-228, 230-237, 239-246, 278-285, 297-304, 356-363, 365-372
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (30)
locale/ar/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/ar/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/de/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/de/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/el/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/el/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/en/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/en/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/es/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/es/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/fr/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/fr/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/it/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/it/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/ja/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/ja/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/ko/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/ko/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/pt/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/pt/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/ru/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/ru/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/tl/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/tl/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/vi/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/vi/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/zh_CN/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/zh_CN/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.polocale/zh_TW/LC_MESSAGES/docs/user/developers/testnet.pois excluded by!**/*.polocale/zh_TW/LC_MESSAGES/docs/user/governance/eight-steps.pois excluded by!**/*.po
📒 Files selected for processing (1)
.tx/config(1 hunks)
🧰 Additional context used
🧠 Learnings (5)
📓 Common learnings
Learnt from: thephez
Repo: dashpay/docs PR: 534
File: locale/en/LC_MESSAGES/docs/user/masternodes/maintenance.po:175-176
Timestamp: 2025-11-12T18:09:41.377Z
Learning: In the dashpay/docs repository, .po files under locale/ directories are automated outputs generated by running the transifex/pushtx.sh script. These files should not be manually edited as changes will be overwritten on the next Transifex sync. Any corrections should be made at the source level in the original documentation files or within Transifex.
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.
📚 Learning: 2025-11-12T18:09:41.377Z
Learnt from: thephez
Repo: dashpay/docs PR: 534
File: locale/en/LC_MESSAGES/docs/user/masternodes/maintenance.po:175-176
Timestamp: 2025-11-12T18:09:41.377Z
Learning: In the dashpay/docs repository, .po files under locale/ directories are automated outputs generated by running the transifex/pushtx.sh script. These files should not be manually edited as changes will be overwritten on the next Transifex sync. Any corrections should be made at the source level in the original documentation files or within Transifex.
Applied to files:
.tx/config
📚 Learning: 2025-11-10T18:51:37.016Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1737-1738
Timestamp: 2025-11-10T18:51:37.016Z
Learning: Repo: dashpay/docs — When examples show dash-cli command output, keep them verbatim (do not remove or tweak fields for clarity), even if multiple versions of a field (e.g., "next" and "next_index") appear. Applies across API docs, including docs/core/api/remote-procedure-calls-wallet.md.
Applied to files:
.tx/config
📚 Learning: 2025-11-10T17:22:58.160Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-call-quick-reference.md:34-34
Timestamp: 2025-11-10T17:22:58.160Z
Learning: In the dashpay/docs repository, RPC documentation descriptions in files like `docs/core/api/remote-procedure-call-quick-reference.md` are derived from the Dash Core application help output. These descriptions should not be modified for grammar or style, as they need to remain consistent with the source application output.
Applied to files:
.tx/config
📚 Learning: 2025-11-10T19:11:33.355Z
Learnt from: thephez
Repo: dashpay/docs PR: 525
File: docs/core/api/remote-procedure-calls-wallet.md:1702-1704
Timestamp: 2025-11-10T19:11:33.355Z
Learning: Repo: dashpay/docs — For ListDescriptors RPC, document Parameter #1 `private` (bool, default false) and note that `mnemonic` and `mnemonicpassphrase` appear only when `private=true` and the wallet was created with a mnemonic. Both fields are strings per Dash Core v23.0 help (scripts/core-rpc-tools/dash-cli-help-23.0.0.jsonl).
Applied to files:
.tx/config
🔇 Additional comments (1)
.tx/config (1)
11-12: Confirm this Transifex configuration change is intentional for your workflow.Web search confirms your settings will work as described: with
keep_translations = false, existing translations are cleared when source strings are updated, whilereplace_edited_strings = falsepreserves manual edits made in the online editor. This is a deviation from Transifex defaults, as the default forkeep_translationsis true (preserve translations).Please confirm this configuration—which clears translations on each source update across all resources—aligns with your translation workflow.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.