Skip to content

pin rpds-py so pypy 3.10 tests pass #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asmacdo merged 1 commit into from
Oct 28, 2025
Merged

pin rpds-py so pypy 3.10 tests pass #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ all =
matplotlib
PyYAML
pyout
# Pin rpds-py to support PyPy 3.10 - https://github.com/con/duct/issues/330
rpds-py<0.28.0
Copy link
Copy Markdown
Member

@yarikoptic yarikoptic Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there must be a way to limit to pypy

Copy link
Copy Markdown
Member

@yarikoptic yarikoptic Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and add comment on why we need it here

Copy link
Copy Markdown
Member

@yarikoptic yarikoptic Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't check but spotted in https://github.com/con/duct/pull/325/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R63

Suggested change
rpds-py<0.28.0
rpds-py<0.28.0; implementation_name == "pypy"



[options.entry_points]
Expand Down
Loading