Conversation
🧪 CI InsightsHere's what we observed from your CI run for 47f9162. 🟢 All jobs passed!But CI Insights is watching 👀 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 7 7
Lines 947 947
Branches 125 125
=======================================
Hits 865 865
Misses 59 59
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodyCBakerPhD
approved these changes
Oct 27, 2025
yarikoptic
reviewed
Oct 31, 2025
| PyYAML | ||
| pyout | ||
| # Pin rpds-py to support PyPy 3.10 - https://github.com/con/duct/issues/330 | ||
| rpds-py<0.28.0 |
Member
There was a problem hiding this comment.
there must be a way to limit to pypy
Member
There was a problem hiding this comment.
and add comment on why we need it here
Member
There was a problem hiding this comment.
didn't check but spotted in https://github.com/con/duct/pull/325/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R63
Suggested change
| rpds-py<0.28.0 | |
| rpds-py<0.28.0; implementation_name == "pypy" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rpds-py is a dependency of jsonschema, which is a dependency of pyout, which is optional.
rpds-py dropped pypy3.10 support last week.
Fixes #330