Skip to content

pin rpds-py so pypy 3.10 tests pass#331

Merged
asmacdo merged 1 commit intocon:mainfrom
asmacdo:rpds-py-pin
Oct 28, 2025
Merged

pin rpds-py so pypy 3.10 tests pass#331
asmacdo merged 1 commit intocon:mainfrom
asmacdo:rpds-py-pin

Conversation

@asmacdo
Copy link
Member

@asmacdo asmacdo commented Oct 27, 2025

rpds-py is a dependency of jsonschema, which is a dependency of pyout, which is optional.

rpds-py dropped pypy3.10 support last week.

Fixes #330

@mergify
Copy link

mergify bot commented Oct 27, 2025

🧪 CI Insights

Here's what we observed from your CI run for 47f9162.

🟢 All jobs passed!

But CI Insights is watching 👀

@asmacdo asmacdo added the semver-tests Add or improve existing tests label Oct 27, 2025
@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.34%. Comparing base (427ab91) to head (47f9162).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #331   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files           7        7           
  Lines         947      947           
  Branches      125      125           
=======================================
  Hits          865      865           
  Misses         59       59           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asmacdo asmacdo changed the title pin rpds-py for pypy 3.10 pin rpds-py so pypy 3.10 tests pass Oct 27, 2025
This was referenced Oct 27, 2025
@asmacdo asmacdo merged commit ddf99d1 into con:main Oct 28, 2025
17 of 18 checks passed
PyYAML
pyout
# Pin rpds-py to support PyPy 3.10 - https://github.com/con/duct/issues/330
rpds-py<0.28.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there must be a way to limit to pypy

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and add comment on why we need it here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't check but spotted in https://github.com/con/duct/pull/325/files#diff-fa602a8a75dc9dcc92261bac5f533c2a85e34fcceaff63b3a3a81d9acde2fc52R63

Suggested change
rpds-py<0.28.0
rpds-py<0.28.0; implementation_name == "pypy"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-tests Add or improve existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pypy 3.10 tests fail

3 participants