test: rename abstract test classes for PHPUnit 10#631
Merged
datamweb merged 2 commits intocodeigniter4:developfrom Feb 8, 2023
Merged
Conversation
b131a67 to
7a45b4f
Compare
kenjis
approved these changes
Feb 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since PHPUnit 10, it is not allowed to name abstract test classes with Test suffix, for example: abstract class MyBaseTest should be renamed to abstract class MyBaseTestCase, etc.
Many existing projects use this naming convention and need refactoring.
more info see : rectorphp/rector-phpunit#151
see https://github.com/codeigniter4/shield/actions/runs/4119008288/jobs/7112201859
related to:
#628 , #629