fix: Custom login fields should work for logging in.#629
Merged
lonnieezell merged 3 commits intocodeigniter4:developfrom Feb 9, 2023
Merged
fix: Custom login fields should work for logging in.#629lonnieezell merged 3 commits intocodeigniter4:developfrom
lonnieezell merged 3 commits intocodeigniter4:developfrom
Conversation
datamweb
reviewed
Feb 8, 2023
datamweb
reviewed
Feb 8, 2023
Co-authored-by: Pooya Parsa Dadashi <pooya_parsa_dadashi@yahoo.com>
datamweb
reviewed
Feb 8, 2023
tests/Authentication/Authenticators/SessionAuthenticatorTest.php
Outdated
Show resolved
Hide resolved
datamweb
approved these changes
Feb 9, 2023
Collaborator
datamweb
left a comment
There was a problem hiding this comment.
LGTM!
Very thanks for addressing this issue.
Member
Author
|
Glad to see this one fixed, myself! you're welcome. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #334
Previously, only
emailandusernamewere actually working as valid fields to login with. This was not the original intention.This changes this to ensure that any field listed within
$validFieldsthat is within theuserstable can be used as a valid login credential for the Session authenticator. All login attempts must still have a password associated.