Fix documentation for $selected argument for radio and checkbox dialogs#41
Merged
clue merged 1 commit intoclue:masterfrom Jul 27, 2016
Merged
Fix documentation for $selected argument for radio and checkbox dialogs#41clue merged 1 commit intoclue:masterfrom
clue merged 1 commit intoclue:masterfrom
Conversation
README.md
Outdated
| @@ -183,10 +183,12 @@ $builder->info($text, $title = null); | |||
| ```php | |||
| $builder->listCheck(array $list, $text = null, $selected = null); | |||
Owner
There was a problem hiding this comment.
$selected should be an array here.
Can you amend your change to explain why? Thanks!
Contributor
Author
There was a problem hiding this comment.
Do you prefer a new commit or an extra one?
Owner
There was a problem hiding this comment.
I think amending your previous commit makes most sense.
Contributor
Author
There was a problem hiding this comment.
I made the amend ;-)
Owner
There was a problem hiding this comment.
Are you sure you've pushed this? :-)
Contributor
Author
There was a problem hiding this comment.
Woops, forgot to git add before git commit --amend xD
32e7fe4 to
ec81ba0
Compare
Owner
|
Thanks, much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.