Documentation fixes as promised on bug report#39
Closed
bertvandepoel wants to merge 2 commits intoclue:masterfrom
Closed
Documentation fixes as promised on bug report#39bertvandepoel wants to merge 2 commits intoclue:masterfrom
bertvandepoel wants to merge 2 commits intoclue:masterfrom
Conversation
Owner
|
The changes LGTM, much appreciated 👍 Sorry for being nitpicky, but may I ask you split this up into two separate PRs? |
Contributor
Author
|
I presume that means I need to cherry pick each of those into a seperate branch because you can only PR from the head? |
Owner
|
Yeah, cherry-picking into 2 separate branches is the way to go 👍 |
Contributor
Author
|
It took some time (server failure, data recovery is the best in these conditions) but you should have PRs from two seperate branches 😄 |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.