Improve PHP 8.4+ support by avoiding implicitly nullable types#19
Merged
clue merged 1 commit intoclue:masterfrom Aug 6, 2025
Merged
Improve PHP 8.4+ support by avoiding implicitly nullable types#19clue merged 1 commit intoclue:masterfrom
clue merged 1 commit intoclue:masterfrom
Conversation
818d758 to
558b1d0
Compare
clue
approved these changes
Aug 6, 2025
Owner
clue
left a comment
There was a problem hiding this comment.
@PaulRotmann Thanks for looking into this, changes LGTM! 
Will take a look at the remainder from #21/#18 when time allows (or somebody sponsors this work) ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset improves PHP 8.4+ support by avoiding implicitly nullable types as discussed in reactphp/promise#260. The same idea applies, but v1 requires manual type checks to support legacy PHP versions as the nullable type syntax requires PHP 7.1+ otherwise.
Builds on top of #15, #16, reactphp/promise#260 and others.