Skip to content

Simplify usage by supporting new default loop#15

Merged
clue merged 1 commit intoclue:masterfrom
SimonFrings:loop
Aug 3, 2021
Merged

Simplify usage by supporting new default loop#15
clue merged 1 commit intoclue:masterfrom
SimonFrings:loop

Conversation

@SimonFrings
Copy link
Contributor

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$client = new Clue\React\Ssdp\Client($loop);

// new (using default loop)
$factory = new Clue\React\Ssdp\Client();

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229 and reactphp/event-loop#232

Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue added this to the v0.1.0 milestone Aug 3, 2021
@clue clue merged commit be08f1f into clue:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants