Skip to content

Add repository_url to reproducible attributes#94

Merged
srikrsna-buf merged 1 commit intobufbuild:mainfrom
styurin:st/repository_url
Apr 24, 2025
Merged

Add repository_url to reproducible attributes#94
srikrsna-buf merged 1 commit intobufbuild:mainfrom
styurin:st/repository_url

Conversation

@styurin
Copy link
Copy Markdown
Contributor

@styurin styurin commented Jan 10, 2025

When repository_url is used, bazel complains about reproducible form:

DEBUG: Rule 'rules_buf_toolchains' indicated that a canonical reproducible form can be obtained by dropping arguments ["repository_url"]

repository_url should be included in the attributes returned from the rule to indicate that it can also be used to generate reproducible form.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 10, 2025

CLA assistant check
All committers have signed the CLA.

@styurin styurin marked this pull request as ready for review January 10, 2025 17:48
@styurin
Copy link
Copy Markdown
Contributor Author

styurin commented Jan 10, 2025

@srikrsna-buf please, take a look

@srikrsna-buf srikrsna-buf merged commit 35b4617 into bufbuild:main Apr 24, 2025
@srikrsna-buf srikrsna-buf mentioned this pull request May 7, 2025
srikrsna-buf added a commit that referenced this pull request May 7, 2025
## What's Changed
* Use canonical_id in rctx.download and use the latest github release
version by @Strum355 in #62
* Fix running tests in Windows by @jchadwick-buf in
#79
* Update bzlmod example to be able to use toolchain by @sfroment in
#81
* Fix extensions.bzl to allow for multiple versions by @filippobrizzi in
#88
* Add repository_url to reproducible attributes by @styurin in
#94
* Sort targets in the buf_breaking rules by @dspencer12 in
#100
* Add `buf_format` rule by @srikrsna-buf in
#105

## New Contributors
* @Strum355 made their first contribution in
#62
* @jchadwick-buf made their first contribution in
#79
* @sfroment made their first contribution in
#81
* @filippobrizzi made their first contribution in
#88
* @dspencer12 made their first contribution in
#101
* @styurin made their first contribution in
#94

**Full Changelog**:
v0.3.0...v0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants