Skip to content

Fix extensions.bzl to allow for multiple versions#88

Merged
srikrsna-buf merged 1 commit into
bufbuild:mainfrom
filippobrizzi:patch-1
Dec 10, 2024
Merged

Fix extensions.bzl to allow for multiple versions#88
srikrsna-buf merged 1 commit into
bufbuild:mainfrom
filippobrizzi:patch-1

Conversation

@filippobrizzi
Copy link
Copy Markdown
Contributor

Current code has a bug, where if there are multiple registration it will not run with error:

Error in sorted: unsupported comparison: dict <=> dict

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

@srikrsna-buf srikrsna-buf merged commit 0acf580 into bufbuild:main Dec 10, 2024
@srikrsna-buf srikrsna-buf mentioned this pull request Dec 10, 2024
@srikrsna-buf srikrsna-buf mentioned this pull request May 7, 2025
srikrsna-buf added a commit that referenced this pull request May 7, 2025
## What's Changed
* Use canonical_id in rctx.download and use the latest github release
version by @Strum355 in #62
* Fix running tests in Windows by @jchadwick-buf in
#79
* Update bzlmod example to be able to use toolchain by @sfroment in
#81
* Fix extensions.bzl to allow for multiple versions by @filippobrizzi in
#88
* Add repository_url to reproducible attributes by @styurin in
#94
* Sort targets in the buf_breaking rules by @dspencer12 in
#100
* Add `buf_format` rule by @srikrsna-buf in
#105

## New Contributors
* @Strum355 made their first contribution in
#62
* @jchadwick-buf made their first contribution in
#79
* @sfroment made their first contribution in
#81
* @filippobrizzi made their first contribution in
#88
* @dspencer12 made their first contribution in
#101
* @styurin made their first contribution in
#94

**Full Changelog**:
v0.3.0...v0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants