Skip to content

Save R,Z locations for all four corners of each cell#168

Merged
johnomotani merged 2 commits into
masterfrom
save-all-corners
Mar 13, 2023
Merged

Save R,Z locations for all four corners of each cell#168
johnomotani merged 2 commits into
masterfrom
save-all-corners

Conversation

@johnomotani

Copy link
Copy Markdown
Collaborator

The corner positions can be useful for plotting, or coupling to other codes. Saving all four corners separately means no special handling is needed for branch cuts or boundaries, and there are no missing values (e.g. upper corners at an upper boundary).

  • Tests added
  • Udated manual
  • Updated doc/whats-new.md with a summary of the changes

The corner positions can be useful for plotting, or coupling to other
codes. Saving all four corners separately means no special handling is
needed for branch cuts or boundaries, and there are no missing values
(e.g. upper corners at an upper boundary).
@johnomotani johnomotani added the enhancement New feature or request label Feb 13, 2023
New major version of black introduced some minor changes to code
formatting.
@johnomotani

Copy link
Copy Markdown
Collaborator Author

@mikekryjak @gjwilkie you might find this useful!

@mikekryjak

Copy link
Copy Markdown
Collaborator

Amazing, thank you @johnomotani !!

@johnomotani johnomotani merged commit 6a1d0d7 into master Mar 13, 2023
@johnomotani johnomotani deleted the save-all-corners branch March 13, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants