Fix ZonedDateTime::with bug when empty fields is provided#650
Merged
Manishearth merged 1 commit intomainfrom Dec 12, 2025
Merged
Fix ZonedDateTime::with bug when empty fields is provided#650Manishearth merged 1 commit intomainfrom
Manishearth merged 1 commit intomainfrom
Conversation
Manishearth
approved these changes
Dec 12, 2025
Contributor
|
This bug is not present in V8 since V8 handles this check in C++. |
github-merge-queue Bot
pushed a commit
to boa-dev/boa
that referenced
this pull request
Dec 13, 2025
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request fixes two failing tests for ZonedDateTime that flagged with some of the new test262 tests. The 3rd and final broken test is fixed by boa-dev/temporal#650
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rejects empty fields being provided to
ZonedDateTime::with_with_provider.It also adds an
ErrorMessagevalue for empty fields.