Skip to content

Fix ZonedDateTime.from order of operations bugs#4565

Merged
HalidOdat merged 1 commit into
boa-dev:mainfrom
nekevss:zdt-bug-fixes
Dec 13, 2025
Merged

Fix ZonedDateTime.from order of operations bugs#4565
HalidOdat merged 1 commit into
boa-dev:mainfrom
nekevss:zdt-bug-fixes

Conversation

@nekevss
Copy link
Copy Markdown
Member

@nekevss nekevss commented Dec 12, 2025

This Pull Request fixes two failing tests for ZonedDateTime that flagged with some of the new test262 tests.

The 3rd and final broken test is fixed by boa-dev/temporal#650

@github-actions
Copy link
Copy Markdown

Test262 conformance changes

Test result main count PR count difference
Total 52,598 52,598 0
Passed 49,383 49,385 +2
Ignored 2,134 2,134 0
Failed 1,081 1,079 -2
Panics 0 0 0
Conformance 93.89% 93.89% +0.00%
Fixed tests (2):
test/built-ins/Temporal/ZonedDateTime/from/options-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/observable-get-overflow-argument-string-invalid.js (previously Failed)

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.32%. Comparing base (6ddc2b4) to head (02edc83).
⚠️ Report is 615 commits behind head on main.

Files with missing lines Patch % Lines
.../engine/src/builtins/temporal/zoneddatetime/mod.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4565       +/-   ##
===========================================
+ Coverage   47.24%   57.32%   +10.08%     
===========================================
  Files         476      504       +28     
  Lines       46892    57926    +11034     
===========================================
+ Hits        22154    33206    +11052     
+ Misses      24738    24720       -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nekevss nekevss requested a review from a team December 12, 2025 14:39
@nekevss nekevss added A-Bug Something isn't working C-Builtins PRs and Issues related to builtins/intrinsics labels Dec 12, 2025
Copy link
Copy Markdown
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 😄

@HalidOdat HalidOdat added this pull request to the merge queue Dec 13, 2025
Merged via the queue into boa-dev:main with commit c163676 Dec 13, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Bug Something isn't working C-Builtins PRs and Issues related to builtins/intrinsics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants