Skip to content

feat(desktop): add nest commit identity guidance with human sign-off#929

Merged
wpfleger96 merged 7 commits into
mainfrom
paul/nest-agents-git-identity
Jun 9, 2026
Merged

feat(desktop): add nest commit identity guidance with human sign-off#929
wpfleger96 merged 7 commits into
mainfrom
paul/nest-agents-git-identity

Conversation

@wpfleger96

@wpfleger96 wpfleger96 commented Jun 9, 2026

Copy link
Copy Markdown
Collaborator

Adds a ## Git Commit Identity section to the nest AGENTS.md template (desktop/src-tauri/src/managed_agents/nest_agents.md) establishing how agents handle commit trailers. Agent name and email are configured automatically by the harness — the instructions focus solely on the human accountability trailers that agents must add.

The section covers:

  • Human sign-off (required) — every commit includes a Signed-off-by trailer for the responsible human operator.
  • Human credit (Co-authored-by) — every commit also includes a Co-authored-by trailer for the same human (identical name/email), placed before Signed-off-by. GitHub uses Co-authored-by for contribution-graph credit; Signed-off-by alone does not grant it.
  • Identity discovery — read git config user.name/user.email from the working repo to get the human operator's identity for trailers; if user.email is empty, stop and ask the operator rather than fabricating a sign-off.
  • Signing — agents sign if they have a registered key; unverified commits are acceptable until agent SSH keys are provisioned. Do NOT use the human's signing key.
  • Verify before pushinggit log -1 shows the human's Signed-off-by trailer.

Also removes the standalone Never push without approval bullet from Core Guidelines, which contradicted the new section's pre-push verification workflow.

Bumps NEST_AGENTS_VERSION 3 → 4 so existing nest installs refresh the template on next launch.

Agents committing inside Sprout-managed worktrees were producing
unverified commits authored by their sprout-agent npub instead of the
human operator, mis-attributing work across the whole team. Add a "Git
Commit Identity" section to the nest AGENTS.md template covering author
identity, signing, Co-authored-by attribution, and DCO sign-off.

Bump NEST_AGENTS_VERSION 3 -> 4 so existing installs pick up the new
static content on next regenerate; without it the version gate skips
the refresh and the guidance never reaches deployed nests.

Co-authored-by: Paul <4a1bfa0013bc6d14a8d600d8bf6392efefbd2a26ac3c96c9b2a106b0d12297ca@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: npub1fgdl5qqnh3k3f2xkqrvt7cujalhm623x4s7fdjdj5yrtp5fzjl9qrjpucw <4a1bfa0013bc6d14a8d600d8bf6392efefbd2a26ac3c96c9b2a106b0d12297ca@sprout-oss.stage.blox.sqprod.co>
@wpfleger96 wpfleger96 requested a review from a team as a code owner June 9, 2026 19:01
…human sign-off

Signed-off-by: Will Pfleger <wpfleger@squareup.com>
@wpfleger96 wpfleger96 changed the title feat(desktop): document git commit identity rules in nest template fix(desktop): flip nest commit identity rule to agent-as-author with human sign-off Jun 9, 2026
npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 and others added 2 commits June 9, 2026 15:41
Signed-off-by: Will Pfleger <wpfleger@squareup.com>
Co-authored-by: Will Pfleger <wpfleger@squareup.com>
Signed-off-by: Will Pfleger <wpfleger@squareup.com>
@wpfleger96 wpfleger96 force-pushed the paul/nest-agents-git-identity branch from c84c7f9 to 7225458 Compare June 9, 2026 20:15
Co-authored-by: Will Pfleger <wpfleger@squareup.com>
Signed-off-by: Will Pfleger <wpfleger@squareup.com>
@wpfleger96 wpfleger96 changed the title fix(desktop): flip nest commit identity rule to agent-as-author with human sign-off docs(desktop): add git commit identity section to nest template Jun 9, 2026
@wpfleger96 wpfleger96 changed the title docs(desktop): add git commit identity section to nest template docs(desktop): add git commit identity rules to nest AGENTS.md template Jun 9, 2026
@wpfleger96 wpfleger96 changed the title docs(desktop): add git commit identity rules to nest AGENTS.md template feat(desktop): add nest commit identity guidance for agent-as-author with human sign-off Jun 9, 2026
npub1fgdl5qqnh3k3f2xkqrvt7cujalhm623x4s7fdjdj5yrtp5fzjl9qrjpucw and others added 2 commits June 9, 2026 18:39
…est template

Agent identity (name and email) is set automatically by the harness —
no need for manual GIT_AUTHOR_*/GIT_COMMITTER_* instructions. Keeps
only the Signed-off-by and Co-authored-by guidance that agents need
to follow explicitly.

Signed-off-by: Will Pfleger <wpfleger@squareup.com>
Co-authored-by: Will Pfleger <wpfleger@squareup.com>
Agent git identity (name and email) is configured automatically by the
harness — no need to reference it in the instructions. Keep only the
human sign-off and co-authored-by guidance that agents need to follow.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
@wpfleger96 wpfleger96 changed the title feat(desktop): add nest commit identity guidance for agent-as-author with human sign-off feat(desktop): add nest commit identity guidance with human sign-off Jun 9, 2026
@wpfleger96 wpfleger96 merged commit 165b9f7 into main Jun 9, 2026
15 checks passed
@wpfleger96 wpfleger96 deleted the paul/nest-agents-git-identity branch June 9, 2026 22:46
tlongwell-block pushed a commit that referenced this pull request Jun 10, 2026
* origin/main:
  Fix post-compact handoff context for OpenAI providers (#931)
  chore(release): release version 0.3.15 (#936)
  fix: persona is source of truth at spawn + thread-depth conventions (#930)
  fix: skip avatar reconciliation for legacy agent records (#933)
  feat(desktop): add nest commit identity guidance with human sign-off (#929)
  feat: provider/model selection for personas and runtime-aware env injection (#794)
  fix: reconcile agent profile on startup when relay publish was missed (#921)
  Revamp first-run onboarding (#924)
  Update setup loading screen (#926)
  fix(dm): keep hidden DMs hidden across refetch via relay-signed visibility snapshot (NIP-DV) (#857)
  Maximize desktop window on launch (#925)
  feat: preview features (experiments settings UI) (#888)
  fix(updater): send no-cache header on update check to avoid stale manifest (#922)
  fix(desktop): refresh channel state after unarchive (#923)
  Add channel visibility & ephemeral TTL controls to manage sidebar (#911)
  ci(release): add Intel macOS (x86_64) DMG as a release target (#748)

Signed-off-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co>

# Conflicts:
#	desktop/src/features/sidebar/ui/AppSidebar.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant