Skip to content

Add profile editing controls #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesbillman merged 5 commits into from
Jun 8, 2026
Merged

Add profile editing controls #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae18233
Add profile editing controls
klopez4212 Jun 7, 2026
cd0fb94
Address avatar editor review comments
klopez4212 Jun 7, 2026
7a2674a
Keep hidden avatar color controls out of tab order
klopez4212 Jun 7, 2026
be4b1cc
Let profile Done recover from unsupported clears
klopez4212 Jun 7, 2026
b2de446
Restore avatar draft after unsupported clears
klopez4212 Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
854 changes: 854 additions & 0 deletions desktop/src/features/profile/ui/ProfileAvatarEditor.tsx
View file
Open in desktop

Large diffs are not rendered by default.

513 changes: 513 additions & 0 deletions desktop/src/features/profile/ui/ProfileAvatarEditor.utils.ts
View file
Open in desktop

Large diffs are not rendered by default.

27 changes: 18 additions & 9 deletions desktop/src/features/profile/useAvatarUpload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ type UseAvatarUploadReturn = {
errorMessage: string | null;
clearError: () => void;
openPicker: () => void;
uploadFile: (file: File) => Promise<void>;
handleFileChange: (event: React.ChangeEvent<HTMLInputElement>) => void;
};

Expand All @@ -37,15 +38,8 @@ export function useAvatarUpload({
inputRef.current?.click();
}, []);

const handleFileChange = React.useCallback(
async (event: React.ChangeEvent<HTMLInputElement>) => {
const file = event.target.files?.[0];
event.target.value = "";

if (!file) {
return;
}

const uploadFile = React.useCallback(
async (file: File) => {
if (!AVATAR_IMAGE_TYPES.includes(file.type)) {
setErrorMessage("Choose a PNG, JPG, GIF, or WebP image.");
return;
Expand Down Expand Up @@ -79,12 +73,27 @@ export function useAvatarUpload({
[onUploadSuccess],
);

const handleFileChange = React.useCallback(
(event: React.ChangeEvent<HTMLInputElement>) => {
const file = event.target.files?.[0];
event.target.value = "";

if (!file) {
return;
}

void uploadFile(file);
},
[uploadFile],
);

return {
inputRef,
isUploading,
errorMessage,
clearError,
openPicker,
uploadFile,
handleFileChange,
};
}
Loading