Skip to content

Add profile editing controls#895

Merged
wesbillman merged 5 commits into
kennylopez-settings-section-formattingfrom
kennylopez-profile-editing
Jun 8, 2026
Merged

Add profile editing controls#895
wesbillman merged 5 commits into
kennylopez-settings-section-formattingfrom
kennylopez-profile-editing

Conversation

@klopez4212

Copy link
Copy Markdown
Contributor

Summary

  • Add edit/done profile metadata controls inside the settings profile page.
  • Add a profile avatar editor with upload, image URL, emoji avatar, and color controls while keeping mobile behavior as-is.
  • Add the app-wide emoji burst provider used by the avatar picker feedback.
  • Split the avatar editor helper logic into ProfileAvatarEditor.utils.ts so the editor stays under the file-size gate.
  • Expand profile E2E coverage for metadata saves, avatar uploads, emoji avatars, menu presence, and settings shell behavior.

Validation

  • pnpm check
  • pnpm typecheck
  • pnpm test
  • pnpm test:e2e:integration -- profile.spec.ts

@klopez4212 klopez4212 marked this pull request as ready for review June 7, 2026 17:41
@klopez4212 klopez4212 requested a review from a team as a code owner June 7, 2026 17:41

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 023e0c44a8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/profile/ui/ProfileAvatarEditor.utils.ts
@klopez4212 klopez4212 force-pushed the kennylopez-settings-section-formatting branch from 8b76452 to 31ed2d1 Compare June 7, 2026 17:51
@klopez4212 klopez4212 force-pushed the kennylopez-profile-editing branch from 023e0c4 to 474ec31 Compare June 7, 2026 17:51

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 474ec317ea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/profile/ui/ProfileAvatarEditor.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8ff54343ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/profile/ui/ProfileAvatarEditor.tsx
@klopez4212 klopez4212 force-pushed the kennylopez-settings-section-formatting branch from 31ed2d1 to 890d859 Compare June 7, 2026 18:20
@klopez4212 klopez4212 force-pushed the kennylopez-profile-editing branch from 8ff5434 to 7a2674a Compare June 7, 2026 18:20

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a2674abf2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/settings/ui/ProfileSettingsCard.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: be4b1ccc65

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/src/features/settings/ui/ProfileSettingsCard.tsx
@wesbillman wesbillman merged commit f740f76 into kennylopez-settings-section-formatting Jun 8, 2026
15 checks passed
@wesbillman wesbillman deleted the kennylopez-profile-editing branch June 8, 2026 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants