fix(release): locate signed NSIS installer as the Windows updater artifact#1032
Open
wpfleger96 wants to merge 1 commit into
Open
fix(release): locate signed NSIS installer as the Windows updater artifact#1032wpfleger96 wants to merge 1 commit into
wpfleger96 wants to merge 1 commit into
Conversation
…ifact The Locate Windows build artifacts step globbed for a *.nsis.zip updater archive that Tauri 2.x no longer produces. With createUpdaterArtifacts the NSIS installer is signed in place — <name>-setup.exe plus a detached <name>-setup.exe.sig — and that signed installer IS the updater artifact; the .nsis.zip was the deprecated v1Compatible format. The dead glob returned empty and tripped the not-found guard, failing every Windows release after a clean installer build. Capture the installer's own .sig and rename it in lockstep with the exe so the rolling-release archive name and its detached signature stay consistent. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Locate Windows build artifactsstep inrelease.ymlglobbed for a*.nsis.zipupdater archive that Tauri 2.x no longer produces. WithcreateUpdaterArtifacts: true(the v2 updater format), the NSIS installer is signed in place —<name>-setup.exeplus a detached<name>-setup.exe.sig— and that signed installer is the updater artifact. The.nsis.zipwas the deprecated v1Compatible format.The dead glob returned empty and tripped the not-found guard, failing every Windows release run after a clean installer build (the
*.exefind succeeds, then the*.nsis.zipfind fails). This was the sole remaining blocker on Windows releases once the sqlite link fix (#1029) landed.Fix
Capture the installer's own
.sig(SIG="${EXE}.sig") instead of globbing for the nonexistent.nsis.zip, and rename it in lockstep with the.exeso the rolling-release archive name and its detached signature stay consistent. Thearchive/archive_name/sigoutputs now point at the marked installer and its sig.The Windows
latest.jsonupdater URL consequently points at the full*_alpha-unsigned.exerather than a.nsis.zip— correct v2 updater behavior, symmetric with Linux serving the renamed.AppImagedirectly. The name chain is single-sourced: uploaded-object-name,archive_name, manifest URL, and verify URL all derive from the oneoutputs.archivepair and cannot diverge.Related: #1029 (Windows sqlite link fix, already merged — this is the next layer down).