fix(desktop): make Windows release compile cleanly#1029
Merged
Conversation
The release workflow's Windows job failed to compile two source files containing platform-conditional code never validated on Windows: PR CI builds the desktop app for macOS/Linux only, so these surfaced only at release time. migration.rs called std::os::unix::fs::symlink unconditionally in the dev-only worktree-sync helper; gate it behind a #[cfg]-selected symlink helper (no-op on non-unix), matching the existing copy_dir_all convention. media.rs cast a file handle to isize, but windows-sys 0.61 changed HANDLE to *mut c_void; cast to the matching type. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
…ared setup The arm64 'release' job created the GitHub release objects and computed the version string, so the other three platform jobs were chained behind it via needs: release. That serialized four independent builds and coupled them to arm64 codesign — a branch dispatch could never reach the Windows job because arm64's OIDC AssumeRole is denied on non-release refs, skipping everything downstream. Extract a no-OIDC 'setup' job that determines the version and creates both the versioned and rolling releases up front. All four platform jobs now depend only on setup and run concurrently; setup is the sole release creator, the platform jobs are pure uploaders, removing the create race the concurrency change would otherwise expose. Rolling-release uploads and the latest.json assembly are gated on tag pushes so a branch dispatch can validate compiles without clobbering the live auto-update channel. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
After the source-level Windows compile fixes, the release build reached the link stage and failed with LNK1181: cannot open input file 'sqlite3.lib'. rusqlite was declared without the bundled feature, so libsqlite3-sys tried to link a system sqlite3.lib that windows-latest does not provide. Enable rusqlite's bundled feature to compile and statically link SQLite from vendored source, removing the system-library dependency on all platforms. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
tlongwell-block
pushed a commit
that referenced
this pull request
Jun 13, 2026
* origin/main: (33 commits) fix(desktop): make Windows release compile cleanly (#1029) Add production Docker Compose bundle (#985) feat(profile): show active turn badges on agent profile panel and popover (#1026) chore(release): release version 0.3.20 (#1027) fix(release): resolve Windows sidecar path and Linux AppImage updater format (#1024) chore(release): release version 0.3.19 (#1014) fix(release): ignore prerelease tags in changelog generation (#1021) fix: repair main build after cross-PR merge skew (#1020) feat(agents): show per-turn duration and prune dead turns within ~25s of host crash (#1017) fix(release): replace hermit with native tool setup on Windows job (#1018) feat(acp): surface error-class outcomes to the activity feed only, never the channel (#1010) fix(desktop): migrate Sprout workspace storage (#1016) feat(auth): force token refresh on rejected token (401/403), never the browser (#1015) fix(release): mark prerelease versions so they do not become latest (#1013) feat(acp): implement systemPrompt with protocol version gating (#981) fix(release): update repository name check from block/sprout to block/buzz (#1012) feat(release): all-OS desktop builds + universal auto-update manifest (#1011) Add relay disconnect UX: friendly errors, reconnect, cached identity (#1004) feat(agents): add active turn indicators to Agents Menu (#1005) ci: add fork guards to docker, release, and auto-tag workflows (#1007) ... Co-authored-by: npub1t2tgm7d8f995uqvmnm8h88sg3wnpp9a5xysjf6dg3tjmgt3ltulqdp8ehr <5a968df9a7494b4e019b9ecf739e088ba61097b4312124e9a88ae5b42e3f5f3e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1t2tgm7d8f995uqvmnm8h88sg3wnpp9a5xysjf6dg3tjmgt3ltulqdp8ehr <5a968df9a7494b4e019b9ecf739e088ba61097b4312124e9a88ae5b42e3f5f3e@sprout-oss.stage.blox.sqprod.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.20 release workflow's Windows job fails to compile two desktop source files that contain platform-conditional code never validated on Windows. PR CI builds the desktop app for macOS and Linux only, so these errors surface only at release time — which is why every prior Windows release stopped at the same point.
desktop/src-tauri/src/migration.rssync_shared_agent_data(the dev-only worktree-sync helper) calledstd::os::unix::fs::symlinkunconditionally at three sites.std::os::unixdoes not exist on Windows. This adds a#[cfg]-selectedsymlinkhelper —std::os::unix::fs::symlinkon unix, a no-opOk(())on non-unix — and routes the three sites through it. This matches the convention already used bycopy_dir_allin the same file. Worktree sync only runs whenBUZZ_SHARE_IDENTITY=1, a dev-only env var no release user sets, so the non-unix no-op path is unreachable in production.desktop/src-tauri/src/commands/media.rsfd_real_pathcast a file handle withas isize, butwindows-sys 0.61changedHANDLEto*mut core::ffi::c_void. The cast now targets the matching pointer type.macOS and Linux builds are unaffected — the
#[cfg(unix)]branch is byte-identical to the previous behavior.Verification
cargo check(native, unix) passes clean. Localcargo check --target x86_64-pc-windows-msvcfrom macOS does not reach typechecking: theaws-lc-sysbuild script fails to compile its C sources againstwindows.h(no MSVC headers on the host) — a*-systoolchain gap unrelated to this change. The Windows release CI job is the authoritative gate.