Skip to content

Add icon policy documentation#143

Closed
Bosch-0 wants to merge 21 commits intobitcoin-core:masterfrom
Bosch-0:icon_policy
Closed

Add icon policy documentation#143
Bosch-0 wants to merge 21 commits intobitcoin-core:masterfrom
Bosch-0:icon_policy

Conversation

@Bosch-0
Copy link

@Bosch-0 Bosch-0 commented Dec 3, 2020

I created some documentation as to how icons should be prepared, optimized, styled, contributed and attributed within Bitcoin Core. Having guidelines for iconography helps with making applications more consistent and efficient.

The current icon set does not yet follow this policy but I will be updating them in future PRs. To see the current icon set using this policy see this figma source file.

@jonasschnelli
Copy link
Contributor

Concept ACK. Great work.
My only question would be, it this should belong to the root docs/ directory or if we should place it in src/qt/res/.

Bosch-0 and others added 19 commits December 4, 2020 17:30
Changed optimized spelling to optimised.

Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>
Copy link
Author

@Bosch-0 Bosch-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestions :)

@RandyMcMillan
Copy link
Contributor

I like the idea of putting it in the /res folder.
Maybe even just name it README.md if it lands in the /res folder?
This may be a good place to add logo/branding specification notes in the future.

@RandyMcMillan
Copy link
Contributor

RandyMcMillan commented Dec 4, 2020

This may be helpful in getting this PR to pass.
The parent commits are probably too stale.

#139 (comment)

@Bosch-0
Copy link
Author

Bosch-0 commented Dec 7, 2020

My only question would be, it this should belong to the root docs/ directory or if we should place it in src/qt/res/.

Yes this is probably a better location for this, I'll move the file and squash the commits

@jarolrod
Copy link
Contributor

You should probably squash the commits

@RandyMcMillan
Copy link
Contributor

I still think it should be named README.md
There is other documentation we could add to this later. Why not be proactive?

Otherwise ACK

@Bosch-0
Copy link
Author

Bosch-0 commented Jan 9, 2021

Moved #178

@Bosch-0 Bosch-0 closed this Jan 9, 2021
@bitcoin-core bitcoin-core locked as resolved and limited conversation to collaborators Aug 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants