doc: Improve gui/src/qt README.md#139
Conversation
hebasto
left a comment
There was a problem hiding this comment.
For editing *.ui files the Qt Designer is enough for me, but this opinion is personal, ofc.
|
ACK modulo 2xcomments |
|
@jarolrod - You should be able to trigger a rebuild yourself. ACK :) |
|
The parent commits never passed CI The current parent commits I suggest rebasing it to As you can see - it passed CIRRUS https://cirrus-ci.com/build/4908623950249984 and travis-ci https://travis-ci.org/github/bitcoin-core/gui/builds/747420647 |
af8c5a5 to
f6584d9
Compare
|
updated to f6584d9 Addressed @hebasto comments and @jonasschnelli suggestions |
f6584d9 to
a9e641d
Compare
|
Implemented @jonatack suggestions. Thanks for the in-depth review! Additionally, I have included some Qt Creator setup instructions for UNIX (Ubuntu & Debian). Windows instructions still need to be done. I will take care of that in a follow-up PR. New Render: src/qt/README.md |
|
Thanks, will re-review. |
jonatack
left a comment
There was a problem hiding this comment.
Almost-ACK, just a couple more items below.
a9e641d to
63d0f29
Compare
|
updated a9e641d -> 63d0f29, addressed @jonatack suggestions |
The current readme is a little bit outdated and contains some grammatical mistakes. This commit updates the doc so that: - It is easier to follow and is more informative - Fixes grammatical mistakes - Modernizes the Qt Creater setup instructions - Adds UNIX instructions for Qt Creator setup
63d0f29 to
5d1f260
Compare
|
ACK 5d1f260 👍🏼 |
Master/Before: Render of Master
PR/After: Render of PR
Changes:
The README.md found in
gui/src/qtseems to not have gotten any love in a while. This PR fixes some grammatical errors, makes it easier to follow, and modernizes the logic of using Qt Creator.Files and Directoriesnow end with a forward slash denoting that they are a directory