Skip to content

test: improve integration test #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
embano1 merged 1 commit into from
Apr 9, 2024
Merged

test: improve integration test #274

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
<aws.schema.registry.version>1.1.15</aws.schema.registry.version>
<ch.qos.logback.version>1.5.3</ch.qos.logback.version>
<com.fasterxml.jackson.version>2.17.0</com.fasterxml.jackson.version>
<com.jayway.jsonpath.version>2.9.0</com.jayway.jsonpath.version>
<commons-codec.version>1.16.1</commons-codec.version>
<commons-logging.version>1.3.1</commons-logging.version>
<connect.api.version>3.7.0</connect.api.version>
Expand All @@ -45,6 +46,11 @@
<artifactId>logback-classic</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.jayway.jsonpath</groupId>
<artifactId>json-path-assert</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-lang3</artifactId>
Expand Down Expand Up @@ -151,6 +157,11 @@
<scope>import</scope>
<type>pom</type>
</dependency>
<dependency>
<groupId>com.jayway.jsonpath</groupId>
<artifactId>json-path-assert</artifactId>
<version>${com.jayway.jsonpath.version}</version>
</dependency>
<dependency>
<groupId>commons-codec</groupId>
<artifactId>commons-codec</artifactId>
Expand Down
124 changes: 67 additions & 57 deletions src/test/java/software/amazon/event/kafkaconnector/EventBridgeSinkConnectorIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,32 +4,34 @@
*/
package software.amazon.event.kafkaconnector;

import static com.jayway.jsonpath.matchers.JsonPathMatchers.*;
import static java.net.http.HttpClient.*;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static java.util.concurrent.TimeUnit.SECONDS;
import static org.apache.kafka.clients.producer.ProducerConfig.*;
import static org.assertj.core.api.Assertions.assertThat;
import static org.hamcrest.Matchers.*;
import static org.junit.jupiter.api.Assertions.fail;
import static org.junit.jupiter.api.TestInstance.Lifecycle.PER_CLASS;
import static org.testcontainers.shaded.org.awaitility.Awaitility.await;

import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import java.io.File;
import java.io.IOException;
import java.net.URI;
import java.net.http.HttpClient;
import java.net.http.HttpRequest;
import java.net.http.HttpResponse;
import java.nio.file.Path;
import java.time.Duration;
import java.time.LocalDateTime;
import java.time.temporal.ChronoUnit;
import java.util.List;
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicReference;
import org.apache.kafka.clients.producer.KafkaProducer;
import org.apache.kafka.clients.producer.ProducerConfig;
import org.apache.kafka.clients.producer.ProducerRecord;
import org.apache.kafka.common.serialization.StringSerializer;
import org.apache.kafka.connect.json.JsonSerializer;
import org.hamcrest.MatcherAssert;
import org.junit.jupiter.api.*;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
Expand All @@ -38,7 +40,6 @@
import org.testcontainers.containers.wait.strategy.Wait;
import org.testcontainers.junit.jupiter.Container;
import org.testcontainers.junit.jupiter.Testcontainers;
import org.testcontainers.shaded.org.awaitility.Awaitility;
import software.amazon.awssdk.auth.credentials.AwsBasicCredentials;
import software.amazon.awssdk.auth.credentials.StaticCredentialsProvider;
import software.amazon.awssdk.regions.Region;
Expand All @@ -51,7 +52,7 @@
import software.amazon.awssdk.services.sqs.model.*;
import software.amazon.awssdk.utils.ImmutableMap;

@TestInstance(TestInstance.Lifecycle.PER_CLASS)
@TestInstance(PER_CLASS)
@Testcontainers
public class EventBridgeSinkConnectorIT {
// environment variables
Expand Down Expand Up @@ -102,9 +103,11 @@ private static String getKafkaVersion() {
.withEnv("AWS_SECRET_ACCESS_KEY", AWS_SECRET_ACCESS_KEY)
.withEnv(KAFKA_VERSION_ENV, getKafkaVersion())
.withExposedService(
CONNECT_SERVICE, CONNECT_EXPOSED_SERVICE_PORT, Wait.forListeningPort())
CONNECT_SERVICE, CONNECT_EXPOSED_SERVICE_PORT, Wait.forHttp("/connectors"))
.withExposedService(
LOCALSTACK_SERVICE, LOCALSTACK_EXPOSED_SERVICE_PORT, Wait.forListeningPort());
LOCALSTACK_SERVICE,
LOCALSTACK_EXPOSED_SERVICE_PORT,
Wait.forHttp("/_localstack/health"));

private SqsClient sqsClient;
private HttpClient httpClient;
Expand Down Expand Up @@ -177,29 +180,27 @@ public void createAwsResources() {
}

@Test
public void startConnector() {
public void startConnector() throws IOException, InterruptedException {
log.info("creating eventbridge sink connector");
try {
var request =
HttpRequest.newBuilder()
.uri(buildKafkaConnectURI("/connectors/"))
.POST(HttpRequest.BodyPublishers.ofFile(Path.of(CONNECTOR_CONFIG_LOCATION)))
.setHeader("Accept", "application/json")
.setHeader("Content-Type", "application/json")
.build();

var response = httpClient.send(request, HttpResponse.BodyHandlers.ofString());
log.info("kafka connect response {}", response);

var statusCode = response.statusCode();
assertTrue(statusCode >= 200 && statusCode <= 299);
} catch (Exception e) {
fail("could not create connector", e);
}
var request =
HttpRequest.newBuilder()
.uri(buildKafkaConnectURI("/connectors/"))
.POST(HttpRequest.BodyPublishers.ofFile(Path.of(CONNECTOR_CONFIG_LOCATION)))
.setHeader("Accept", "application/json")
.setHeader("Content-Type", "application/json")
.build();

Awaitility.await()
.atMost(Duration.ofSeconds(5))
.until(
var response = httpClient.send(request, HttpResponse.BodyHandlers.ofString());
log.info("kafka connect response {}", response);

assertThat(response.statusCode())
.withFailMessage(() -> "could not create connector")
.isBetween(200, 299);

await()
.atMost(5, SECONDS)
.pollInterval(1, SECONDS)
.untilAsserted(
() -> {
log.info("waiting for eventbridge sink connector to enter {} state", RUNNING_STATE);
var statusRequest =
Expand All @@ -208,8 +209,9 @@ public void startConnector() {
.setHeader("Accept", "application/json")
.build();

var response = httpClient.send(statusRequest, HttpResponse.BodyHandlers.ofString());
return response.body().contains(RUNNING_STATE);
var statusResponse =
httpClient.send(statusRequest, HttpResponse.BodyHandlers.ofString());
assertThat(statusResponse.body()).contains(RUNNING_STATE);
});
log.info("eventbridge sink connector entered {} state", RUNNING_STATE);
}
Expand All @@ -220,13 +222,13 @@ public void sendJsonRecordToKafkaReceiveFromSQS() {

final Map<String, Object> producerConfig =
ImmutableMap.of(
ProducerConfig.BOOTSTRAP_SERVERS_CONFIG,
BOOTSTRAP_SERVERS_CONFIG,
BOOTSTRAP_SERVER,
ProducerConfig.CLIENT_ID_CONFIG,
CLIENT_ID_CONFIG,
UUID.randomUUID().toString(),
ProducerConfig.ACKS_CONFIG,
ACKS_CONFIG,
"all",
ProducerConfig.RETRIES_CONFIG,
RETRIES_CONFIG,
2);

var producer =
Expand All @@ -244,43 +246,51 @@ public void sendJsonRecordToKafkaReceiveFromSQS() {
log.info("sending kafka json test record {} to topic {}", jsonTestEvent, TEST_RESOURCE_NAME);
producer.send(new ProducerRecord<>(TEST_RESOURCE_NAME, TEST_EVENT_KEY, jsonTestEvent)).get();
producer.flush();
producer.close(Duration.of(3, ChronoUnit.SECONDS));
producer.close(Duration.ofSeconds(3));
} catch (Exception e) {
fail("could not send json test record", e);
}
log.info("successfully sent json test record to kafka");

var gotMessageDetailValue = new AtomicReference<JsonNode>(mapper.createObjectNode());
var receivedMessage = new AtomicReference<Message>(null);

log.info("polling sqs queue {} for json test record", getQueueArn());
Awaitility.await()
.atMost(5, TimeUnit.SECONDS)
.pollInterval(1, TimeUnit.SECONDS)
await()
.atMost(5, SECONDS)
.pollInterval(1, SECONDS)
.untilAsserted(
() -> {
var receiveMessageResponse =
var response =
sqsClient.receiveMessage(
ReceiveMessageRequest.builder()
.queueUrl(getQueueUrl())
.maxNumberOfMessages(1)
.build());

List<Message> messages = receiveMessageResponse.messages();
assertEquals(1, messages.size());

var messageBody = messages.get(0).body();
log.info("received sqs message body: {}", messageBody);
var messages = response.messages();
assertThat(messages).hasSize(1);

var detailValue = new ObjectMapper().readTree(messageBody).path("detail");
log.info("retrieved eventbridge event detail value: {}", detailValue);
gotMessageDetailValue.set(detailValue);
receivedMessage.set(messages.get(0));
});

assertTrue(gotMessageDetailValue.get().path("partition").asInt(-1) >= 0);
assertTrue(gotMessageDetailValue.get().path("offset").asInt(-1) >= 0);
assertEquals(TEST_EVENT_KEY, gotMessageDetailValue.get().path("topic").asText(""));
assertEquals(TEST_EVENT_KEY, gotMessageDetailValue.get().path("key").asText(""));
assertEquals(jsonTestEvent, gotMessageDetailValue.get().path("value"));
var messageBody = receivedMessage.get().body();
log.info("received sqs message body: {}", messageBody);

MatcherAssert.assertThat(
messageBody,
isJson(
withJsonPath(
"$.detail",
allOf(
hasJsonPath("partition", greaterThanOrEqualTo(0)),
hasJsonPath("offset", greaterThanOrEqualTo(0)),
hasJsonPath("topic", equalTo(TEST_EVENT_KEY)),
hasJsonPath("key", equalTo(TEST_EVENT_KEY)),
hasJsonPath(
"value.sentTimestamp",
equalTo(jsonTestEvent.get("sentTimestamp").asText())),
hasJsonPath(
"value.message", equalTo(jsonTestEvent.get("message").asText()))))));
}

private String getQueueUrl() {
Expand Down