test: improve integration test #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
embano1
reviewed
Apr 7, 2024
src/test/java/software/amazon/event/kafkaconnector/EventBridgeSinkConnectorIT.java
Outdated
Show resolved
Hide resolved
src/test/java/software/amazon/event/kafkaconnector/EventBridgeSinkConnectorIT.java
Outdated
Show resolved
Hide resolved
272b422 to
f90f6f7
Compare
Improve existing integration test by: * waiting for service endpoints instead of port (Kafka, LocalStack), port might by available but service is not ready * use [Awailitility](http://www.awaitility.org/) consistent * use [JsonPath](https://github.com/json-path/JsonPath) for asserting JSON content Closes aws#273.
f90f6f7 to
34ad137
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve existing integration test by:
Test Steps
Checklist:
Related Issue
#273.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.