This repository was archived by the owner on Apr 6, 2018. It is now read-only.
Update to atom 1.0 api (fixes #552)#553
Closed
lightsofapollo wants to merge 1 commit into
Closed
Conversation
Contributor
|
Thanks for the PR! It looks like some of the tests are failing. I'll try to look into why when I get a chance. |
|
#545 has the same changes and I just got the tests to work FWIW. It seems a little ugly how it's traversing the text editor component though |
Contributor
|
Looks like this was fixed by fc24df5? |
Contributor
|
Yeah, this has been taken care of now. Thanks for looking into it though, @lightsofapollo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am usually a heavy (m)vim user but today I tried to play with atom and generally like it... The big bug I hit was not being able to see my search input as I typed.. I am only somewhat confident this makes sense but it looks right given atom core code/deprecation warnings.