Use space-pen dependencies for input views#545
Conversation
|
Doh, seems to fail a bunch of tests somehow. Not sure if it makes more sense to update the tests against the deprecated views, or update how the input editor view works |
|
Most of the failing tests seem to stem from needing to change how events are bound to the text editor now that it uses shadow DOM. I can update the bindings with handleEvents: ->
input = $ @editor[0].rootElement.querySelector 'input'
if @singleChar?
input.on 'textInput', @autosubmit
@editor.on 'core:confirm', @confirm
@editor.on 'core:cancel', @cancel
input.on 'blur', @canceland single character motions are working again, but the specs still are failing |
|
@maxbrunsfeld - I was able to return to this and get the tests to work, the specs had the same issue getting a reference to the text editor input through the shadow DOM mentioned above. It seems like there has to be a better way to hook to the input, but I couldn't find it in the docs. I'd be happy to update if someone would point me in the right direction |
|
Issue is fixed on master. |
|
Hey @MattKunze, didn't mean to ignore this. @tmm1 and I ended up fixing this a different way with the added benefit of not relying on jQuery any more. |
|
No worries, just glad to see the issue fixed! |
This probably isn't the best way to fix this, the views seem to be deprecated. Not sure how to go about replacing the views with an
<atom-text-editor>thoughfixes #544