feat: update atoms to selenium 4.19.0 basis#375
Conversation
mykola-mokhnach
left a comment
There was a problem hiding this comment.
I assume you would want to release this PR together with #376
|
It would be nice if we could add an e2e test for the react input case for the future |
|
Sounds good. Let me check Jlipps's thoughts as well in #376 |
|
I'm going to merge this only since I have closed #376 and moving to appium/appium#20004 (comment) idea for this case. I think it is better than adding atoms's customization only in Appium Atoms. |
## [11.1.0](v11.0.9...v11.1.0) (2024-04-16) ### Features * update atoms to selenium 4.19.0 basis ([#375](#375)) ([cc5a084](cc5a084))
|
🎉 This PR is included in version 11.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
jlipps
left a comment
There was a problem hiding this comment.
Pretty sure this will bring back a bug that I fixed in the atoms, but which the Selenium people did not like and reverted since it caused some other issues. Are all the tests passing with these changes?
|
Oh, do you mean SeleniumHQ/selenium#12704 ...? Actually it reverted SeleniumHQ/selenium#12557 . Hm, shall we apply SeleniumHQ/selenium#12557 to our appium atoms? @jlipps yea, CI here and https://github.com/appium/appium-xcuitest-driver were fine with this. |
|
ah, maybe Maybe we should note it in this atoms note. -> https://github.com/appium/appium-remote-debugger/blob/master/atoms-notes.md Updated |
|
yep exactly. thanks! |
Diffs: