Conversation
|
PR Description updated to latest commit (5bf228b)
|
PR Review
✨ Review tool usage guide:Overview: The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
See the review usage page for a comprehensive guide on using this tool. |
PR Code Suggestions
✨ Improve tool usage guide:Overview:
See the improve usage page for a comprehensive guide on using this tool. |
CI Failure Feedback(Checks updated until commit ae0b070)
✨ CI feedback usage guide:The CI feedback tool (
In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR: where Configuration options
See more information about the |
whimboo
left a comment
There was a problem hiding this comment.
Thank you @diemol. I think that it would be good as well to have a test for this case similar like https://github.com/SeleniumHQ/selenium/blob/trunk/javascript/atoms/test/text_test.html#L261.
…ong-capitalized-text-when-underscores-are-used-since-pr-8736
|
Thank you @diemol!! |
User description
Credit to @whimboo
Fixes #13779
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
Type
bug_fix
Description
capitalizetext transformation incorrectly capitalized text when underscores were present.Changes walkthrough
dom.js
Fix Incorrect Capitalization in `capitalize` Text Transformationjavascript/atoms/dom.js
capitalizetext transformation tofix incorrect capitalization when underscores are used.
the regex for all browsers.