ADFA-4593: wire three-tier help to all native controls (conexión total)#152
Merged
Merged
Conversation
Central registry + one-line-per-screen wiring: - TooltipWiring.wireAll(root): iterates a central R.id -> tag map (74 controls across 12 screens) and attaches the long-press tooltip to each control present in that view tree (null-safe; absent controls skipped). - TooltipTag: full tag registry (one constant per control), single source of truth. - wireAll(view) called once in each Fragment.onViewCreated (Sync, Feedback, SetupSection, About, Usage, Dashboard, Deploy) and each Activity.onCreate after setContentView (Setup, Qr, Portal, CrashReport). MainActivity switched from the 4 individual calls to wireAll(decorView). No content changes: controls without help text in the DB simply show nothing on long-press. The 4 Main tooltips (seeded in #151) still work. All 74 tags' content + translations land in the follow-up PR. dash_tunnel excluded (tunnel cleanup). No new dependencies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADFA-4593 — Conexión total (wiring)
Wires the three-tier help mechanism (merged in the mechanism PR) to all native controls. No help content is added here — that lands in the follow-up content + l10n PR.
Approach — central registry, one line per screen
TooltipWiring.wireAll(root)iterates a centralR.id -> tagmap (74 controls across 12 screens) and attaches the long-press tooltip to each control present in that view tree. Null-safe: a control absent from the current screen is skipped, so one shared map works everywhere.TooltipTagis the full tag registry (one constant per control) — single source of truth, matched by the content PR's.potags.wireAll(...)is called once in eachFragment.onViewCreated(Sync, Feedback, SetupSection, About, Usage, Dashboard, Deploy) and eachActivity.onCreateaftersetContentView(Setup, Qr, Portal, CrashReport). MainActivity switched from its 4 individual calls towireAll(decorView).Behavior
dash_tunnelexcluded (removed by the tunnel cleanup). No new dependencies.Scope / next
Testing
Relates to ADFA-4536; sibling of ADFA-4594.