Skip to content

Traffic Dump: Allow unlimited disk utilization#9186

Merged
bneradt merged 2 commits intoapache:masterfrom
bneradt:traffic_dump_unlimited_disk_size_option
Nov 15, 2022
Merged

Traffic Dump: Allow unlimited disk utilization#9186
bneradt merged 2 commits intoapache:masterfrom
bneradt:traffic_dump_unlimited_disk_size_option

Conversation

@bneradt
Copy link
Contributor

@bneradt bneradt commented Nov 8, 2022

The traffic_dump.so plugin has a --limit argument that specifies how much disk space the plugin will use before stopping writing out new sessions to replay files. This patch allows the user to configure unrestricted disk utilization by making --limit optional and making the absence of --limit imply no disk utilization.

@bneradt bneradt added the Plugins label Nov 8, 2022
@bneradt bneradt added this to the 10.0.0 milestone Nov 8, 2022
@bneradt bneradt self-assigned this Nov 8, 2022
The traffic_dump.so plugin has a --limit argument that specifies how
much disk space the plugin will use before stopping writing out new
sessions to replay files. This patch allows the user to configure
unrestricted disk utilization by passing a value of 0 to --limit.
@bneradt bneradt force-pushed the traffic_dump_unlimited_disk_size_option branch from e5ef523 to 1f22f12 Compare November 9, 2022 22:17
@bneradt bneradt requested a review from moonchen November 15, 2022 00:18
@moonchen
Copy link
Contributor

A couple of suggestions:

  1. We could make it such that --limit is optional, and not specifying --limit means unlimited.
  2. I think the implementation would be simpler if the "unlimited" value was INT64_MAX.

@bneradt
Copy link
Contributor Author

bneradt commented Nov 15, 2022

A couple of suggestions:

  1. We could make it such that --limit is optional, and not specifying --limit means unlimited.
  2. I think the implementation would be simpler if the "unlimited" value was INT64_MAX.

Yes, good points. I'll just make the --limit optional. Thanks @moonchen .

Without --limit specified, there is no disk usage limitation
enforcement.
@bneradt bneradt force-pushed the traffic_dump_unlimited_disk_size_option branch from c9b5edb to 260fd29 Compare November 15, 2022 18:57
Copy link
Contributor

@moonchen moonchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bneradt bneradt merged commit 9e0257e into apache:master Nov 15, 2022
@bneradt bneradt deleted the traffic_dump_unlimited_disk_size_option branch November 15, 2022 19:35
@zwoop
Copy link
Contributor

zwoop commented Nov 17, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Nov 17, 2022
zwoop pushed a commit that referenced this pull request Nov 17, 2022
The traffic_dump.so plugin has a --limit argument that specifies how
much disk space the plugin will use before stopping writing out new
sessions to replay files. This patch allows the user to configure
unrestricted disk utilization by not using the --limit argument which
was previous a required argument.

(cherry picked from commit 9e0257e)
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
The traffic_dump.so plugin has a --limit argument that specifies how
much disk space the plugin will use before stopping writing out new
sessions to replay files. This patch allows the user to configure
unrestricted disk utilization by not using the --limit argument which
was previous a required argument.

(cherry picked from commit 9e0257e)
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x:
  Revert "Make separate read and write vc_handlers (apache#8301)"
  AuTest: Update to Proxy Verifier 2.5.2 (apache#9223)
  AuTest: Update to Proxy Verifier v2.5.0 (apache#9221)
  Updated ChangeLog
  Adding back set_connect_fail for generic I/O error (apache#9181)
  AuTest: make MakeATSProcess accessible for TestRuns (apache#9195)
  Traffic Dump: Allow unlimited disk utilization (apache#9186)
  AuTest: bind stdout/stderr to traffic.out (apache#8919)
  Adds support for serving statichit content out of a directory (apache#9107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants