Adding back set_connect_fail for generic I/O error#9181
Merged
serrislew merged 5 commits intoapache:masterfrom Nov 15, 2022
Merged
Adding back set_connect_fail for generic I/O error#9181serrislew merged 5 commits intoapache:masterfrom
serrislew merged 5 commits intoapache:masterfrom
Conversation
bneradt
reviewed
Nov 7, 2022
Contributor
bneradt
left a comment
There was a problem hiding this comment.
Thanks for the PR. A few quick questions:
- Can we add an autest for this?
- You mention in the description that this was removed in a previous patch. Which PR took this out? I didn't find it when scanning patches to this file, so I'm probably not looking in the right place.
- Just checking: I notice this is marked for 9.2.x. Was the issue you're fixing introduced with the hostdb restructure in #8953? If so, that restructure only went into master/10-Dev.
Contributor
Author
|
Yes, I will definitely add an autest. The PR is #7580. I spoke to Susan about this and it was initially deleted since NET_EVENT_OPEN should have preemptively set the server connect failure code (EIO) but the failed case I've been testing doesn't reach this event. Instead of setting the EIO as I have it now (since it could possibly override other more specific failures), I will set it before NET_EVENT_OPEN so it applies to all cases. |
Contributor
Author
|
[approve ci] |
4b3c398 to
befad54
Compare
bneradt
requested changes
Nov 11, 2022
Contributor
bneradt
left a comment
There was a problem hiding this comment.
Looks good. Thanks for adding the test. I just have a few minor comments.
SolidWallOfCode
pushed a commit
to SolidWallOfCode/trafficserver
that referenced
this pull request
Nov 15, 2022
* Adding back set connect fail for generic I/O error * Set generic error earlier & added autest * Format issues * Lower timeout limit * Improved autest with comments and additional checks Co-authored-by: Serris Lew <lserris@apple.com>
zwoop
pushed a commit
that referenced
this pull request
Nov 17, 2022
* Adding back set connect fail for generic I/O error * Set generic error earlier & added autest * Format issues * Lower timeout limit * Improved autest with comments and additional checks Co-authored-by: Serris Lew <lserris@apple.com> (cherry picked from commit ea01774)
Contributor
|
Cherry-picked to v9.2.x |
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* Adding back set connect fail for generic I/O error * Set generic error earlier & added autest * Format issues * Lower timeout limit * Improved autest with comments and additional checks Co-authored-by: Serris Lew <lserris@apple.com> (cherry picked from commit ea01774)
masaori335
pushed a commit
to masaori335/trafficserver
that referenced
this pull request
Feb 21, 2023
* asf/9.2.x: Revert "Make separate read and write vc_handlers (apache#8301)" AuTest: Update to Proxy Verifier 2.5.2 (apache#9223) AuTest: Update to Proxy Verifier v2.5.0 (apache#9221) Updated ChangeLog Adding back set_connect_fail for generic I/O error (apache#9181) AuTest: make MakeATSProcess accessible for TestRuns (apache#9195) Traffic Dump: Allow unlimited disk utilization (apache#9186) AuTest: bind stdout/stderr to traffic.out (apache#8919) Adds support for serving statichit content out of a directory (apache#9107)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without setting the generic I/O error, the server doesn't know it has failed and
t_state.current.server->had_connect_fail()inHttpSM::track_connect_fail()always returns false. As a result, when the server has exhausted its attempts, it fails to reachmark_host_failureand does not update that HostDBInfo entry's last_failure timeout fieldI am not sure why it was deleted before and do not see its replacement where the server's
connect_resultfield is updated