Skip to content

Re-introduce import to get man_pages list available for sphinx.#8859

Merged
bneradt merged 1 commit intoapache:masterfrom
jbfavre:upstream_manpages_build_fix
May 23, 2022
Merged

Re-introduce import to get man_pages list available for sphinx.#8859
bneradt merged 1 commit intoapache:masterfrom
jbfavre:upstream_manpages_build_fix

Conversation

@jbfavre
Copy link
Contributor

@jbfavre jbfavre commented May 22, 2022

As explain in #8858, current man pages generation is broken.
Re-introducing the import fixes it.
Error has been introduced in commit 005b04b
Closes #8858

bneradt
bneradt requested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@bneradt bneradt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@bneradt bneradt added this to the 10.0.0 milestone May 23, 2022
@bneradt
Copy link
Contributor

bneradt commented May 23, 2022

Thank you for working on this.

@jbfavre jbfavre force-pushed the upstream_manpages_build_fix branch from 693fc0f to 217c239 Compare May 23, 2022 15:34
@jbfavre jbfavre force-pushed the upstream_manpages_build_fix branch from 3ec4a4e to ec274f4 Compare May 23, 2022 15:36
@jbfavre
Copy link
Contributor Author

jbfavre commented May 23, 2022 •
edited
Loading

Thank you for working on this.

You're welcome.
Always happy to help 😉

@bneradt
Copy link
Contributor

bneradt commented May 23, 2022

I noticed that the autest failed in remap_reload. I've filed an issue to track that test's failure:
#8860

Once the test complete's, I'll re-run autest CI for this PR.

@apache apache deleted a comment from randall May 23, 2022
@bneradt bneradt merged commit 77ab481 into apache:master May 23, 2022
zwoop pushed a commit that referenced this pull request May 25, 2022
@jbfavre @zwoop
Re-introduce import to get man_pages list available for sphinx. Closes …
5c5a030 
…#8858 (#8859)

Spell check
Better comment

(cherry picked from commit 77ab481)
@zwoop
Copy link
Contributor

zwoop commented May 25, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 May 25, 2022
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jun 16, 2022
Fix manpages generation
d6adea9 
Origin: other
Forwarded: apache/trafficserver#8859
Applied-Upstream: apache/trafficserver@77ab481
Last-Update: 2022-05-24

Default documentation build puts everything in a single file
which is not convenient for manpages.
To get separate man pages files, we need to define the
man_pages variable in conf.py
Currently, this variable is defined in manpages.py
but this file is never included into conf.py.
Last-Update: 2022-05-24
Gbp-Pq: Name 0016-fix-manpages-generation.patch
@jbfavre jbfavre deleted the upstream_manpages_build_fix branch June 19, 2022 14:10
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jun 23, 2022
Fix manpages generation
b1833e8 
Origin: other
Forwarded: apache/trafficserver#8859
Applied-Upstream: apache/trafficserver@77ab481
Last-Update: 2022-05-24

Default documentation build puts everything in a single file
which is not convenient for manpages.
To get separate man pages files, we need to define the
man_pages variable in conf.py
Currently, this variable is defined in manpages.py
but this file is never included into conf.py.
Last-Update: 2022-05-24
Gbp-Pq: Name 0016-fix-manpages-generation.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Jul 5, 2022
Fix manpages generation
7897168 
Origin: other
Forwarded: apache/trafficserver#8859
Applied-Upstream: apache/trafficserver@77ab481
Last-Update: 2022-05-24

Default documentation build puts everything in a single file
which is not convenient for manpages.
To get separate man pages files, we need to define the
man_pages variable in conf.py
Currently, this variable is defined in manpages.py
but this file is never included into conf.py.
Last-Update: 2022-05-24
Gbp-Pq: Name 0016-fix-manpages-generation.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Aug 25, 2022
Fix manpages generation
9f7b073 
Origin: other
Forwarded: apache/trafficserver#8859
Applied-Upstream: apache/trafficserver@77ab481
Last-Update: 2022-05-24

Default documentation build puts everything in a single file
which is not convenient for manpages.
To get separate man pages files, we need to define the
man_pages variable in conf.py
Currently, this variable is defined in manpages.py
but this file is never included into conf.py.
Last-Update: 2022-05-24
Gbp-Pq: Name 0016-fix-manpages-generation.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Sep 19, 2022
Fix manpages generation
833c6f2 
Origin: other
Forwarded: apache/trafficserver#8859
Applied-Upstream: apache/trafficserver@77ab481
Last-Update: 2022-05-24

Default documentation build puts everything in a single file
which is not convenient for manpages.
To get separate man pages files, we need to define the
man_pages variable in conf.py
Currently, this variable is defined in manpages.py
but this file is never included into conf.py.
Last-Update: 2022-05-24
Gbp-Pq: Name 0016-fix-manpages-generation.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Nov 1, 2022
Fix manpages generation
a237129 
Origin: other
Forwarded: apache/trafficserver#8859
Applied-Upstream: apache/trafficserver@77ab481
Last-Update: 2022-05-24

Default documentation build puts everything in a single file
which is not convenient for manpages.
To get separate man pages files, we need to define the
man_pages variable in conf.py
Currently, this variable is defined in manpages.py
but this file is never included into conf.py.
Last-Update: 2022-05-24
Gbp-Pq: Name 0016-fix-manpages-generation.patch
raspbian-autopush pushed a commit to raspbian-packages/trafficserver that referenced this pull request Dec 26, 2022
Fix manpages generation
34c4cc0 
Origin: other
Forwarded: apache/trafficserver#8859
Applied-Upstream: apache/trafficserver@77ab481
Last-Update: 2022-05-24

Default documentation build puts everything in a single file
which is not convenient for manpages.
To get separate man pages files, we need to define the
man_pages variable in conf.py
Currently, this variable is defined in manpages.py
but this file is never included into conf.py.
Last-Update: 2022-05-24
Gbp-Pq: Name 0016-fix-manpages-generation.patch
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
@zwoop
Merge remote-tracking branch 'asf/9.2.x' into 9.2.x
f38e06d 
* asf/9.2.x:
  Updated ChangeLog
  Restore down nameservers after they come back online (apache#8847)
  Fix Rocky Linux 8 arm64 GCC Compiler Warnings (apache#8850)
  Fix `COMPRESSION_ERROR` on valid HPACK input (apache#8817)
  remap_stats: convert to using TSHttpTxnPristineUrlGet and TSHttpTxnClientReqGet for hostname, remove pre remap continuation (apache#8362)
  Re-introduce import to get man_pages list available for sphinx. Closes apache#8858 (apache#8859)
  Add missing configuration files man pages (apache#8861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bneradt bneradt bneradt approved these changes

Assignees

@jbfavre jbfavre

Labels

Documentation

Projects

None yet

Milestone

9.2.0

Development

Successfully merging this pull request may close these issues.

Unable to build manpages for 9.1.2

3 participants

@jbfavre @bneradt @zwoop