Skip to content

remap_stats: convert to using TSHttpTxnPristineUrlGet and TSHttpTxnClientReqGet#8362

Merged
traeak merged 1 commit intoapache:masterfrom
traeak:remap_stats_leak
Nov 10, 2021
Merged

remap_stats: convert to using TSHttpTxnPristineUrlGet and TSHttpTxnClientReqGet#8362
traeak merged 1 commit intoapache:masterfrom
traeak:remap_stats_leak

Conversation

@traeak
Copy link
Contributor

@traeak traeak commented Sep 28, 2021

remap_stats: convert to using TSHttpTxnPristineUrlGet and TSHttpTxnClienReqGet only during TXN_CLOSE hook.
remove pre remap continuation
post remap continuation now only sets a value.
also fixes and adds an autest for --post-remap-host
Includes memory leak fix for hostname when the old post_remap hook wasn't hit.

Regression tested for some days using the default (post remap) configuration with cloned prod traffic. Also flipped to using -P (pristine) and values seem to match.

…ientReqGet for hostname, remove pre remap continuation

also fixes and adds an autest for --post-remap-host
@traeak traeak requested a review from bryancall as a code owner September 28, 2021 17:57
@traeak traeak marked this pull request as draft September 29, 2021 14:43
@traeak traeak marked this pull request as ready for review September 29, 2021 14:51
@randall randall added this to the 10.0.0 milestone Oct 4, 2021
@randall randall added the Plugins label Oct 4, 2021
@bryancall bryancall requested a review from randall October 4, 2021 23:11
@traeak traeak merged commit 0e59150 into apache:master Nov 10, 2021
zwoop pushed a commit that referenced this pull request May 25, 2022
…ientReqGet for hostname, remove pre remap continuation (#8362)

also fixes and adds an autest for --post-remap-host

(cherry picked from commit 0e59150)
@zwoop
Copy link
Contributor

zwoop commented May 25, 2022

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 May 25, 2022
@bryancall bryancall changed the title remap_stats: convert to using TSHttpTxnPristineUrlGet and TSHttpTxnClienReqGet remap_stats: convert to using TSHttpTxnPristineUrlGet and TSHttpTxnClientReqGet Jun 14, 2022
bryancall pushed a commit that referenced this pull request Jun 15, 2022
…ientReqGet for hostname, remove pre remap continuation (#8362)

also fixes and adds an autest for --post-remap-host

(cherry picked from commit 0e59150)
@bryancall bryancall modified the milestones: 9.2.0, 9.1.X Jun 15, 2022
@bryancall bryancall added this to the 9.1.3 milestone Jun 23, 2022
@traeak traeak deleted the remap_stats_leak branch January 13, 2023 18:33
masaori335 pushed a commit to masaori335/trafficserver that referenced this pull request Feb 21, 2023
* asf/9.2.x:
  Updated ChangeLog
  Restore down nameservers after they come back online (apache#8847)
  Fix Rocky Linux 8 arm64 GCC Compiler Warnings (apache#8850)
  Fix `COMPRESSION_ERROR` on valid HPACK input (apache#8817)
  remap_stats: convert to using TSHttpTxnPristineUrlGet and TSHttpTxnClientReqGet for hostname, remove pre remap continuation (apache#8362)
  Re-introduce import to get man_pages list available for sphinx. Closes apache#8858 (apache#8859)
  Add missing configuration files man pages (apache#8861)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants