fix for collapsed forwarding ink_abort for CacheHitFresh fail#8613
Merged
traeak merged 1 commit intoapache:masterfrom Jan 25, 2022
Merged
fix for collapsed forwarding ink_abort for CacheHitFresh fail#8613traeak merged 1 commit intoapache:masterfrom
traeak merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
[approve ci debian] |
ywkaras
approved these changes
Jan 25, 2022
zwoop
pushed a commit
that referenced
this pull request
Jan 25, 2022
(cherry picked from commit 0e00889)
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: Updated ChangeLog Add SSLSessionDup for older OpenSSL and BoringSSL (apache#8578) use shared pointer to help with high memory utilization (apache#8498) Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (apache#8621) check size of session, and free sessions the ATS way (apache#8330) free sessions when timeout (apache#8356) Fix 32bit build failure on Odroid Xu-4 (apache#8626) TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (apache#8617) SNIConfig (tunnel_route): Change the way we extract matched subgroups from the server name. (apache#8589) fix for collapsed forwarding ink_abort for CacheHitFresh fail (apache#8613) Do not turn off cache for internal requests (apache#8266) Rate Limit Plugin: Re-enable VConnection when SNI is empty (apache#8625) Removes hard dependency on having perl installed (apache#8611)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an abort when
CONFIG proxy.config.http.cache.open_write_fail_action INT 5is set which rewinds the state machine to before cache read/write.
This was tested by simulating a manifest that updates every 10s with max-age=1 cache control, hitting that asset with a thundering herd.
The failure was happening with a cache hit on a stale manifest.
While this "fix" allows ATS to to run without aborting, under testing 1 or more transactions end up with a client timeout with no bytes transferred.