Do not turn off cache for internal requests#8266
Conversation
zwoop
left a comment
There was a problem hiding this comment.
How does this work to make sure it doesn’t serve the auth request via a cached response?
The plugin doesn't make sure that auth requests are not served from the cache. Disabling cache in auth proxy for existing remap( existing behavior) also doesn't guarantee that as auth requests may go to a different remap rule. |
|
[approve ci] |
Added configuration to enable/disable caching. |
|
[approve ci] |
1 similar comment
|
[approve ci] |
bryancall
left a comment
There was a problem hiding this comment.
please update the docs for the PR
updated. |
|
[approve ci] |
* Do not turn off cache for internal requests * Allow configuration to enable/disable caching internal requests * do not enable cache * documentation updated (cherry picked from commit 33cc799)
|
Cherry-picked to v9.2.x |
* asf/9.2.x: Updated ChangeLog Add SSLSessionDup for older OpenSSL and BoringSSL (apache#8578) use shared pointer to help with high memory utilization (apache#8498) Commenting TSHttpTxnCacheLookupStatusGet need_to_revalidate (apache#8621) check size of session, and free sessions the ATS way (apache#8330) free sessions when timeout (apache#8356) Fix 32bit build failure on Odroid Xu-4 (apache#8626) TSHttpTxnCacheLookupStatusGet: call need_to_revalidate (apache#8617) SNIConfig (tunnel_route): Change the way we extract matched subgroups from the server name. (apache#8589) fix for collapsed forwarding ink_abort for CacheHitFresh fail (apache#8613) Do not turn off cache for internal requests (apache#8266) Rate Limit Plugin: Re-enable VConnection when SNI is empty (apache#8625) Removes hard dependency on having perl installed (apache#8611)
As of now, auth proxy disables cache for all the internal requests. Auth proxy disables the cache for any plugin that generates internal requests and goes through the same remap rule. For example, background fetch plugin which generates a internal request doesn't cache internal requests.
If there is a requirement to disable caching, it can be achieved by using the conf_remap plugin.
Update: retained the existing behavior and added a variable to enable caching