Skip to content

Define TS_HTTP_VALUE_BROTLI and TS_HTTP_LEN_BROTLI#8477

Merged
masaori335 merged 1 commit intoapache:masterfrom
masaori335:ts-http-value-brotli
Nov 5, 2021
Merged

Define TS_HTTP_VALUE_BROTLI and TS_HTTP_LEN_BROTLI#8477
masaori335 merged 1 commit intoapache:masterfrom
masaori335:ts-http-value-brotli

Conversation

@masaori335
Copy link
Contributor

@masaori335 masaori335 commented Oct 29, 2021

The proposal is posted on the dev@trafficserver ML.


This is a proposal to add TS_HTTP_VALUE_BROTLI and TS_HTTP_LEN_BROTLI.

Proposal

tsapi const char *TS_HTTP_VALUE_BROTLI; //< "br"
tsapi int TS_HTTP_LEN_BROTLI; //< 2 

The whole code change is #8477.

Motivation

Brotli Compressed Data Format is defined by RFC 7932[*1] and registered as "br" in HTTP Content Coding Registry of IANA [*2].

The compress plugin has its own definition[*3], and I recently added a similar one in the stats-over-http plugin[*4]. It's worth having them in the ts/apidef.h like other HTTP Content Codings ( compress, deflate, and gzip ).

[*1] https://www.rfc-editor.org/rfc/rfc7932.html
[*2] https://www.iana.org/assignments/http-parameters/http-parameters.xhtml#content-coding
[*3]

const char *TS_HTTP_VALUE_BROTLI = "br";
const int TS_HTTP_LEN_BROTLI = 2;

[*4] #8475

Thanks,
Masaori

@masaori335 masaori335 added this to the 10.0.0 milestone Oct 29, 2021
@masaori335 masaori335 self-assigned this Oct 29, 2021
@masaori335 masaori335 force-pushed the ts-http-value-brotli branch 2 times, most recently from 0bd7a49 to 33feb38 Compare October 29, 2021 01:30
@masaori335 masaori335 force-pushed the ts-http-value-brotli branch from 33feb38 to a79bd7d Compare October 29, 2021 04:34
@masaori335 masaori335 marked this pull request as ready for review October 29, 2021 04:34
@masaori335 masaori335 merged commit 332617f into apache:master Nov 5, 2021
zwoop pushed a commit that referenced this pull request Nov 9, 2021
@zwoop
Copy link
Contributor

zwoop commented Nov 9, 2021

Cherry-picked to v9.2.x

@zwoop zwoop modified the milestones: 10.0.0, 9.2.0 Nov 9, 2021
moonchen pushed a commit to moonchen/trafficserver that referenced this pull request Mar 17, 2022
* asf/9.2.x: (50 commits)
  Updated ChangeLog
  Reject Transfer-Encoding in pre-HTTP/1.1 requests (apache#8451)
  Better TLS Secrets Truncation. (apache#8489)
  ssl_secret debug printing: print only the first 50 bytes (apache#8483)
  Define TS_HTTP_VALUE_BROTLI and TS_HTTP_LEN_BROTLI (apache#8477)
  Fix case of brotli (apache#8476)
  TSSslSecretSet: Update SSL_CTX TLS Secrets (apache#8368)
  Adding doc/README.md (apache#8420)
  Doc: fix typos in Strategy documentation (apache#8408)
  Refactors and promotes the Txn Control mechanism with Get() and Set() (apache#8428)
  tests: Add shbang to python scripts with a main (apache#8430)
  Remove empty tests/unit_tests directoy+makefile (apache#8429)
  Adds new API: TSVConnSslSniGet (apache#8313)
  rate_limit: convert to using TSVConnSslSniGet (apache#8414)
  Update the Multiplexer Docs for Multplexed HTTPS Connections (apache#8440)
  bigobj: use automake to build test utilities (apache#8441)
  Make sni.yaml errors cause an unrecoverable TS crash at startup. (apache#8208)
  Fix timeout checks of NetHandler::manage_active_queue() (apache#8287)
  Fix Multiplexer POST/PUT Body Handling (apache#8439)
  Document proxy.config.memory.max_usage (apache#8450)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants