Fix Multiplexer POST Body Handling#8439
Merged
bneradt merged 1 commit intoapache:masterfrom Oct 25, 2021
Merged
Conversation
ae918b1 to
6249e51
Compare
6249e51 to
9a0e94a
Compare
randall
approved these changes
Oct 20, 2021
Member
|
Very nice. |
9a0e94a to
4e36ff1
Compare
The previous Multiplexer Plugin test only verified that the plugin would load without error. This updates the test to verify it can multiplex to multiple hosts, exercising both HTTP and HTTPS connections to the multiplexed hosts. While doing this, I added POST and PUT request method tests. This showed that the plugin could not handle request bodies and simply failed a misconfigured assertion when the request body was processed. This change also fixes that bug in the plugin.
4e36ff1 to
eb288b9
Compare
randall
approved these changes
Oct 25, 2021
zwoop
pushed a commit
that referenced
this pull request
Nov 8, 2021
The previous Multiplexer Plugin test only verified that the plugin would load without error. This updates the test to verify it can multiplex to multiple hosts, exercising both HTTP and HTTPS connections to the multiplexed hosts. While doing this, I added POST and PUT request method tests. This showed that the plugin could not handle request bodies and simply failed a misconfigured assertion when the request body was processed. This change also fixes that bug in the plugin. (cherry picked from commit 636d42a)
Contributor
|
Cherry-picked to v9.2.x |
moonchen
pushed a commit
to moonchen/trafficserver
that referenced
this pull request
Mar 17, 2022
* asf/9.2.x: (50 commits) Updated ChangeLog Reject Transfer-Encoding in pre-HTTP/1.1 requests (apache#8451) Better TLS Secrets Truncation. (apache#8489) ssl_secret debug printing: print only the first 50 bytes (apache#8483) Define TS_HTTP_VALUE_BROTLI and TS_HTTP_LEN_BROTLI (apache#8477) Fix case of brotli (apache#8476) TSSslSecretSet: Update SSL_CTX TLS Secrets (apache#8368) Adding doc/README.md (apache#8420) Doc: fix typos in Strategy documentation (apache#8408) Refactors and promotes the Txn Control mechanism with Get() and Set() (apache#8428) tests: Add shbang to python scripts with a main (apache#8430) Remove empty tests/unit_tests directoy+makefile (apache#8429) Adds new API: TSVConnSslSniGet (apache#8313) rate_limit: convert to using TSVConnSslSniGet (apache#8414) Update the Multiplexer Docs for Multplexed HTTPS Connections (apache#8440) bigobj: use automake to build test utilities (apache#8441) Make sni.yaml errors cause an unrecoverable TS crash at startup. (apache#8208) Fix timeout checks of NetHandler::manage_active_queue() (apache#8287) Fix Multiplexer POST/PUT Body Handling (apache#8439) Document proxy.config.memory.max_usage (apache#8450) ...
bryancall
pushed a commit
that referenced
this pull request
Jun 14, 2022
The previous Multiplexer Plugin test only verified that the plugin would load without error. This updates the test to verify it can multiplex to multiple hosts, exercising both HTTP and HTTPS connections to the multiplexed hosts. While doing this, I added POST and PUT request method tests. This showed that the plugin could not handle request bodies and simply failed a misconfigured assertion when the request body was processed. This change also fixes that bug in the plugin. (cherry picked from commit 636d42a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous Multiplexer Plugin test only verified that the plugin would
load without error. This updates the test to verify it can multiplex to
multiple hosts, exercising both HTTP and HTTPS connections to the
multiplexed hosts.
While doing this, I added POST request method tests. This showed that
the plugin could not handle POST bodies and simply failed a
misconfigured assertion when the request body was processed. This change
also fixes that bug in the plugin.