Skip to content

Refactor and rename restart metrics#10472

Merged
zwoop merged 3 commits intoapache:masterfrom
zwoop:RenameRestartMetrics
Sep 21, 2023
Merged

Refactor and rename restart metrics#10472
zwoop merged 3 commits intoapache:masterfrom
zwoop:RenameRestartMetrics

Conversation

@zwoop
Copy link
Contributor

@zwoop zwoop commented Sep 19, 2023

Much of this is remnants from when we had traffic_manager. So this PR will remove a few metrics that either makes no sense, or have simply stopped being updated already. A few gets a new name, because we don't track "restarts" any more.

@zwoop zwoop added the Metrics label Sep 19, 2023
@zwoop zwoop added this to the 10.0.0 milestone Sep 19, 2023
@zwoop zwoop requested a review from bryancall September 19, 2023 21:38
@zwoop zwoop self-assigned this Sep 19, 2023
@zwoop zwoop force-pushed the RenameRestartMetrics branch 2 times, most recently from 666ae71 to 62fee1d Compare September 19, 2023 22:29
@zwoop zwoop force-pushed the RenameRestartMetrics branch from 62fee1d to 7eb84fe Compare September 19, 2023 22:29
@zwoop zwoop requested a review from brbzull0 September 19, 2023 22:46
@zwoop zwoop force-pushed the RenameRestartMetrics branch from 4e87b4c to 417d1da Compare September 19, 2023 23:27
Copy link
Contributor

@brbzull0 brbzull0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@zwoop zwoop merged commit 7ef597c into apache:master Sep 21, 2023
@zwoop zwoop deleted the RenameRestartMetrics branch September 21, 2023 16:44
cmcfarlen pushed a commit to cmcfarlen/trafficserver that referenced this pull request Jun 3, 2024
* asf/master: (30 commits)
  add conveinience function to lookup name->IntType* (apache#10474)
  cmake: bigobj subdir has executables, not plugins (apache#10481)
  cmake: compile jsonrpc_protocol with -fPIC (apache#10478)
  Make sure new metrics are always considered (apache#10445)
  Refactor and rename restart metrics (apache#10472)
  Fix the SNI and HOST parsing properly (apache#10480)
  slice/Data.h: CID 1508924: Uninitialized scalar field (apache#10470)
  CID 1508882: initialize pointer (apache#10469)
  CID-1512726: Mute coverity, use explicit check for iterator use past end (apache#10467)
  Fix Coverity issue in inliner plugin. (apache#10442)
  Set the proper variable when find_package fails to find the package (apache#10468)
  CID1508860: double lock confusion (apache#10443)
  Stop using functions that are unavailable on the latest quiche (apache#10447)
  Add allow-plain server ports attribute (apache#9574)
  [Fuzzing] move build.sh in trafficserver (apache#10466)
  Some sort of "fix" to mute coverity. (apache#10451)
  CID-1512733: Fix coverity issue (apache#10452)
  Fix cmake autooptions (apache#10456)
  Cmake presets (apache#10457)
  This fixes CID 1518257 (apache#10404)
  ...
@maskit maskit mentioned this pull request Aug 17, 2024
91 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants