CID1508860: double lock confusion #10443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywkaras
reviewed
Sep 19, 2023
iocore/aio/AIO.cc
Outdated
| num_requests--; | ||
| current_req->queued--; | ||
| ink_atomic_increment((int *)¤t_req->pending, 1); | ||
| ink_atomic_increment((int *)&my_aio_req->pending, 1); |
Contributor
There was a problem hiding this comment.
You could get rid of the C-style cast.
ywkaras
reviewed
Sep 19, 2023
| @@ -423,17 +423,15 @@ ink_aio_thread_num_set(int thread_num) | |||
| void * | |||
| AIOThreadInfo::aio_thread_main(AIOThreadInfo *thr_info) | |||
Contributor
There was a problem hiding this comment.
Not directly relevant to this PR, but thr_info is redundant, it's the same as the this pointer in this function.
Contributor
|
The AIO code seems scary bad in general. |
ywkaras
reviewed
Sep 19, 2023
iocore/aio/AIO.cc
Outdated
| ink_atomic_increment(¤t_req->requests_queued, -1); | ||
| ink_atomic_increment(&my_aio_req->requests_queued, -1); | ||
| #ifdef AIO_STATS | ||
| ink_atomic_increment((int *)¤t_req->pending, -1); |
Contributor
Author
There was a problem hiding this comment.
Yep, I missed some inside the conditional code. Thanks!
ywkaras
reviewed
Sep 19, 2023
| ink_atomic_increment((int *)¤t_req->pending, 1); | ||
| ink_atomic_increment((int *)&my_aio_req->pending, 1); | ||
| #endif | ||
| ink_mutex_release(&my_aio_req->aio_mutex); |
ywkaras
approved these changes
Sep 19, 2023
cmcfarlen
pushed a commit
to cmcfarlen/trafficserver
that referenced
this pull request
Jun 3, 2024
* asf/master: (30 commits) add conveinience function to lookup name->IntType* (apache#10474) cmake: bigobj subdir has executables, not plugins (apache#10481) cmake: compile jsonrpc_protocol with -fPIC (apache#10478) Make sure new metrics are always considered (apache#10445) Refactor and rename restart metrics (apache#10472) Fix the SNI and HOST parsing properly (apache#10480) slice/Data.h: CID 1508924: Uninitialized scalar field (apache#10470) CID 1508882: initialize pointer (apache#10469) CID-1512726: Mute coverity, use explicit check for iterator use past end (apache#10467) Fix Coverity issue in inliner plugin. (apache#10442) Set the proper variable when find_package fails to find the package (apache#10468) CID1508860: double lock confusion (apache#10443) Stop using functions that are unavailable on the latest quiche (apache#10447) Add allow-plain server ports attribute (apache#9574) [Fuzzing] move build.sh in trafficserver (apache#10466) Some sort of "fix" to mute coverity. (apache#10451) CID-1512733: Fix coverity issue (apache#10452) Fix cmake autooptions (apache#10456) Cmake presets (apache#10457) This fixes CID 1518257 (apache#10404) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder if coverity is confused by following the
current_reqpointer for the unlock call vsmy_aio_reqfor the lock. I removed thecurrent_reqvariable as it isn't necessary.I also moved the release call before incrementing metrics since the lock doesn't need to be held for that.
Fixes #10430