build: Skip loading example data from configs in CI - #12610
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12610 +/- ##
==========================================
- Coverage 66.75% 62.25% -4.51%
==========================================
Files 1015 1015
Lines 49633 49658 +25
Branches 4839 4845 +6
==========================================
- Hits 33133 30915 -2218
- Misses 16377 18546 +2169
- Partials 123 197 +74
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
thank you so much for this PR, Rob! This is really helpful! 🙏 |
Member
Author
|
Shaves a minute or two off of the e2e test initialization. |
robdiciuccio
marked this pull request as ready for review
January 20, 2021 03:09
willbarrett
approved these changes
Jan 25, 2021
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
Feb 3, 2021
* master: (23 commits) feat(explore): clear search on dataset change (apache#12909) chore: remove SIP-38 feature flag (apache#12894) fix: Config for dataset health check (apache#12906) fix(chart): allow null for most query object props (apache#12905) feat: add separate endpoint to fetch function names for autocomplete (apache#12840) chore: add required review on master (apache#12694) fix: comment typo (apache#12898) Migrates Radio component from Bootstrap to AntD. (apache#12738) fix: allow users to reset their passwords (apache#12886) fix(explore): missing select when groupby without metrics (apache#12890) refactor: dbapi exception mapping for dbapi's (apache#12869) feat(style-theme): add support for custom superset themes (apache#12858) chore(lint): fix pre-commit error (apache#12884) refactor(color-schemes): refactor setting of color schemes (apache#12857) feat(native-filters): Add defaultValue for Native filters modal (apache#12199) feat(release): add github token to changelog script (apache#12872) fix(menu): always show settings dropdown (apache#12877) Migrates Label component from Bootstrap to AntD. (apache#12774) [Helm] Automate datasource import (apache#10771) build: Skip loading example data from configs in CI (apache#12610) ...
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* Skip loading example data from configs in CI * Use .test suffix for example data required by e2e tests * Address linting error with regex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Don't load data for new example dashboards (via
examples.load_from_configs) that are not required for e2e tests. Suffix yaml configs required for e2e tests with.test, e.g.Unicode_Cloud.test.yaml.TEST PLAN
Cypress tests should pass.
ADDITIONAL INFORMATION