feat(native-filters): Add defaultValue for Native filters modal by simcha90 · Pull Request #12199 · apache/superset

simcha90 · 2020-12-24T13:21:04Z

SUMMARY

Add support for defaultValue in Native Filters Config Modal per filter type.

Changes:

Native Filters Config Modal

added Select to choose filter type (now supports only Select filter and Range filter)
added SuperChart that renders appropriate Native filter as default value selector
added defaultValueQueries to keep updated queriesData that will passed to SuperChart
added defaultValueFormData to keep updated form data that will passed SuperChart
dataset now managed by Ant forms

Select Native filter

now works only with array default values

Filter Bar

added currentState to nativeFilters.filtersState in redux to correct save and update defaultValues for resetAll case and others
setExtraFormData hook upgraded to pass currentState

Flows:

In Filters Config Modal

When change dataset -> reset column field -> reset default values
When change column field -> reset default values
When change filter type -> reset default values
When clicks allows multiple values -> reset default values

In Filter Bar

When clicks Reset all should return to default values
When update some default value in Filters Config Modal, it should update also current value in Filter Bar

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-01-28.at.17.12.04.mov

TEST PLAN

Check above flows
No need check default values for Range filter (it should be fixed in other PR)

ADDITIONAL INFORMATION

Has associated issue: fix(native-filters): Setting default value #12465
Changes UI
Requires DB Migration.
Confirm DB Migration upgrade and downgrade tested.
Introduces new feature or API
Removes existing feature or API

…erset into filter_type

� Conflicts: � superset-frontend/spec/javascripts/dashboard/components/nativeFilters/ScopingTree_spec.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterScope.tsx � superset-frontend/src/dashboard/components/nativeFilters/ScopingTree.tsx � superset-frontend/src/dashboard/components/nativeFilters/state.ts � superset-frontend/src/dashboard/components/nativeFilters/utils.ts

� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx

junlincc · 2021-01-28T08:11:38Z

closes #12713

codecov-io · 2021-01-28T15:45:29Z

Codecov Report

Merging #12199 (10529e9) into master (2b9d579) will decrease coverage by 1.35%.
The diff coverage is 39.24%.

@@            Coverage Diff             @@
##           master   #12199      +/-   ##
==========================================
- Coverage   63.23%   61.88%   -1.36%     
==========================================
  Files        1021      535     -486     
  Lines       50145    20037   -30108     
  Branches     5204     5242      +38     
==========================================
- Hits        31708    12399   -19309     
+ Misses      18222     7424   -10798     
+ Partials      215      214       -1

Flag	Coverage Δ
javascript	`61.88% <39.24%> (-0.06%)`	⬇️
python	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...et-frontend/src/dashboard/actions/nativeFilters.ts	`34.78% <0.00%> (ø)`
...ard/components/nativeFilters/FilterConfigModal.tsx	`69.74% <ø> (ø)`
...t-frontend/src/dashboard/reducers/nativeFilters.ts	`34.78% <ø> (ø)`
...src/filters/components/Select/AntdSelectFilter.tsx	`0.00% <0.00%> (ø)`
...et-frontend/src/filters/components/Select/types.ts	`0.00% <ø> (ø)`
superset-frontend/src/filters/utils.ts	`88.88% <ø> (ø)`
...hboard/components/nativeFilters/CascadePopover.tsx	`19.11% <7.69%> (+0.93%)`	⬆️
...c/dashboard/components/nativeFilters/FilterBar.tsx	`51.36% <30.00%> (+3.29%)`	⬆️
...nd/src/dashboard/components/nativeFilters/state.ts	`59.09% <36.73%> (-6.95%)`	⬇️
...oard/components/nativeFilters/FilterConfigForm.tsx	`70.00% <55.55%> (-18.89%)`	⬇️
... and 514 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b9d579...10529e9. Read the comment docs.

simcha90 · 2021-01-28T16:39:44Z

@agatapst @junlincc @villebro I synced this PR with master and updated it, so I think it's ready to review, if you think that this PR relevant for settings defaultValue in native filters

junlincc

Thank you Simcha for the PR! a few issues found in this branch but not in master

when i open the dashboard modal, screen below is what i see. have to click "+" to expand

reset button doesn't work
after selecting filter type, default select dropdown does not show. "No Results" but there actually are options

@simcha90 you have rebased right?

junlincc · 2021-01-28T23:46:28Z

also from the UX standpoint, filter values select probably more than most of the time. @simcha90 @agatapst I think we should check allow multiple-selections box checked by default in the modal, for both default value setting and filter value select

� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx

fix: Reset all fixed

simcha90 · 2021-01-31T14:43:20Z

@junlincc Hi fixed your notes (about 3. it works for me, but may it was fixed by my other changes).
I also needed update some part of code to cause Reset All work, so I also updated description of PR with all changes

About multiple values, it can be good idea but I think in other PR in order to not increase size of this one, because implementing of this feature caused some cascading changes in other parts of code, so it have now XL size :)

cc @villebro

villebro

First pass comments.

villebro · 2021-02-01T15:30:06Z

  };
  column: string;
-  defaultValue: string;
+  defaultValue: any;


Should this be CurrentFilterState?

explained in bottom comment 👇 :)

villebro · 2021-02-01T15:30:17Z

+  defaultValue: any;
+  currentValue?: any;


it's value that we are passing to the native filter, so it should be currentValue together with defaultValue and not currentState according current apis

I think may be we need to discuss in future if we want to render some things like Allow multiple selection checkbox inside of native filter chart so it should be really changed to currentState but for now all filters working only with currentValue

* master: (23 commits) feat(explore): clear search on dataset change (apache#12909) chore: remove SIP-38 feature flag (apache#12894) fix: Config for dataset health check (apache#12906) fix(chart): allow null for most query object props (apache#12905) feat: add separate endpoint to fetch function names for autocomplete (apache#12840) chore: add required review on master (apache#12694) fix: comment typo (apache#12898) Migrates Radio component from Bootstrap to AntD. (apache#12738) fix: allow users to reset their passwords (apache#12886) fix(explore): missing select when groupby without metrics (apache#12890) refactor: dbapi exception mapping for dbapi's (apache#12869) feat(style-theme): add support for custom superset themes (apache#12858) chore(lint): fix pre-commit error (apache#12884) refactor(color-schemes): refactor setting of color schemes (apache#12857) feat(native-filters): Add defaultValue for Native filters modal (apache#12199) feat(release): add github token to changelog script (apache#12872) fix(menu): always show settings dropdown (apache#12877) Migrates Label component from Bootstrap to AntD. (apache#12774) [Helm] Automate datasource import (apache#10771) build: Skip loading example data from configs in CI (apache#12610) ...

…he#12199) * refactor: sync Scoping tree with Forms data * refactor: update scoping tree * refactor: update scope tree logic to be more UX friendly * test: fix tests * lint: fix lin CR notes * chore: temp * fix: fix jsx * feat: Init value * refactor: move effect to utils * chore: add comments * feat: updates for default value in native filters * refactor: move multi values management to Modal * feat: added currentState to filterState fix: Reset all fixed * style: update filter styles * fix: process selection of same filter * fix: fix double choose select * fix: fix order of cascading filters * fix: fix CR comments * fix: fix CR comments

simcha90 added 11 commits December 22, 2020 11:36

refactor: sync Scoping tree with Forms data

ff3a06b

refactor: update scoping tree

540db22

refactor: update scope tree logic to be more UX friendly

e85b8c7

test: fix tests

da9887f

lint: fix lin CR notes

4ea8525

chore: temp

829cdb2

fix: fix jsx

a5c3467

Merge branch 'sync-scoping' of github.com:simchaNielsen/incubator-sup…

03e6d82

…erset into filter_type

feat: Init value

d20dca0

refactor: move effect to utils

f154f49

chore: add comments

7c851e7

pull-request-size Bot added the size/XL label Dec 24, 2020

junlincc added the assigned:nielsen Assigned to the nielsen team label Dec 24, 2020

simcha90 closed this Jan 20, 2021

simcha90 mentioned this pull request Jan 27, 2021

fix(native-filters): Setting default value #12465

Closed

6 tasks

Merge branch 'master' of github.com:apache/superset into filter_type

1f7861e

� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterConfigForm.tsx � superset-frontend/src/dashboard/components/nativeFilters/FilterConfigModal.tsx

junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label Jan 28, 2021

simcha90 reopened this Jan 28, 2021

feat: updates for default value in native filters

33400b6

pull-request-size Bot added size/L and removed size/XL labels Jan 28, 2021

refactor: move multi values management to Modal

057a6cc

simcha90 changed the title ~~WIP: Add defaultValue for Native filters~~ feat(native-filters): Add defaultValue for Native filters Jan 28, 2021

simcha90 changed the title ~~feat(native-filters): Add defaultValue for Native filters~~ feat(native-filters): Add defaultValue for Native filters modal Jan 28, 2021

junlincc requested review from suddjian and villebro January 28, 2021 21:52

junlincc self-requested a review January 28, 2021 21:55

junlincc reviewed Jan 28, 2021

View reviewed changes

simcha90 added 2 commits January 31, 2021 08:00

Merge branch 'master' of github.com:apache/superset into filter_type

7edf5be

� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar.tsx

feat: added currentState to filterState

51818e6

fix: Reset all fixed

pull-request-size Bot added size/XL and removed size/L labels Jan 31, 2021

simcha90 added 4 commits January 31, 2021 16:49

style: update filter styles

b91b3f1

fix: process selection of same filter

eab3d19

fix: fix double choose select

0b6b82a

fix: fix order of cascading filters

9d2677c

villebro reviewed Feb 1, 2021

View reviewed changes

simcha90 added 2 commits February 2, 2021 07:53

fix: fix CR comments

50f812c

fix: fix CR comments

10529e9

villebro approved these changes Feb 2, 2021

View reviewed changes

villebro merged commit 465d986 into apache:master Feb 2, 2021

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024

Uh oh!

Conversation

simcha90 commented Dec 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

Uh oh!

junlincc commented Jan 28, 2021

Uh oh!

codecov-io commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

simcha90 commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

junlincc left a comment

Choose a reason for hiding this comment

Uh oh!

junlincc commented Jan 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simcha90 commented Jan 31, 2021

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

villebro Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

simcha90 Feb 2, 2021

Choose a reason for hiding this comment

Uh oh!

villebro Feb 1, 2021

Choose a reason for hiding this comment

Uh oh!

simcha90 Feb 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

simcha90 commented Dec 24, 2020 •

edited

Loading

codecov-io commented Jan 28, 2021 •

edited

Loading

simcha90 commented Jan 28, 2021 •

edited

Loading

junlincc commented Jan 28, 2021 •

edited

Loading

simcha90 Feb 2, 2021 •

edited

Loading